LG-9821: Consolidate Phone setup Controller PT 1#8966
Merged
Conversation
…t users to phone single phone setup page
zachmargolis
reviewed
Aug 9, 2023
aduth
reviewed
Aug 17, 2023
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
This is looking good! Left a couple comments
aduth
approved these changes
Aug 22, 2023
| phone: @new_phone_form.phone, | ||
| selected_delivery_method: @new_phone_form.otp_delivery_preference, | ||
| phone_type: @new_phone_form.phone_info&.type, | ||
| selected_default_number: @new_phone_form.otp_make_default_number, |
Contributor
There was a problem hiding this comment.
I noticed a slight difference from main, the selected_default_number parameter is now always present in the URL when confirming a number, and it's false when confirming the first phone number. I don't think this makes a meaningful impact, since I checked that in main, the absence of the parameter is effectively the same as it being false.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-9821
🛠 Summary of changes
Adds a check and redirect to standard phone setup page.