Lg 10556 move error message out of flow session 1 of 2

app/controllers/concerns/idv/document_capture_concern.rb

@@ -23,7 +23,7 @@ def successful_response
 
     # copied from Flow::Failure module
     def failure(message, extra = nil)
-      flow_session[:error_message] = message if defined?(flow_session)
+      flash[:error] = message
       form_response_params = { success: false, errors: { message: message } }
       form_response_params[:extra] = extra unless extra.nil?
       FormResponse.new(**form_response_params)

app/controllers/idv/agreement_controller.rb

@@ -13,8 +13,6 @@ def show
         'agreement', :view,
         true
       )
-
-      render :show, locals: { flow_session: flow_session }
     end
 
     def update

app/controllers/idv/getting_started_controller.rb

@@ -15,8 +15,6 @@ def show
 
       @sp_name = decorated_session.sp_name || APP_NAME
       @title = t('doc_auth.headings.getting_started', sp_name: @sp_name)
-
-      render :show, locals: { flow_session: flow_session }
     end
 
     def update

app/controllers/idv/hybrid_handoff_controller.rb

@@ -183,7 +183,7 @@ def rate_limited_failure
 
     # copied from Flow::Failure module
     def failure(message, extra = nil)
-      flow_session[:error_message] = message
+      flash[:error] = message
       form_response_params = { success: false, errors: { message: message } }
       form_response_params[:extra] = extra unless extra.nil?
       FormResponse.new(**form_response_params)

app/views/idv/agreement/show.html.erb

@@ -14,9 +14,9 @@
       class: [
         'js-consent-form-alert',
         'margin-bottom-4',
-        flow_session[:error_message].blank? && 'display-none',
+        'display-none',
       ].select(&:present?),
-      message: flow_session[:error_message].presence || t('errors.doc_auth.consent_form'),
+      message: t('errors.doc_auth.consent_form'),
     ) %>
 
 <%= render PageHeadingComponent.new.with_content(t('doc_auth.headings.lets_go')) %>

app/views/idv/getting_started/show.html.erb

@@ -10,9 +10,9 @@
       class: [
         'js-consent-form-alert',
         'margin-bottom-4',
-        flow_session[:error_message].blank? && 'display-none',
+        'display-none',
       ].select(&:present?),
-      message: flow_session[:error_message].presence || t('errors.doc_auth.consent_form'),
+      message: t('errors.doc_auth.consent_form'),
     ) %>
 
 <%= render PageHeadingComponent.new.with_content(@title) %>

spec/controllers/idv/link_sent_controller_spec.rb

@@ -171,7 +171,7 @@
           put :update
 
           expect(response).to redirect_to(idv_hybrid_handoff_url)
-          expect(flow_session[:error_message]).to eq(error_message)
+          expect(flash[:error]).to eq(error_message)
         end
       end
 
@@ -182,7 +182,7 @@
           put :update
 
           expect(response).to have_http_status(204)
-          expect(flow_session[:error_message]).to eq(t('errors.doc_auth.phone_step_incomplete'))
+          expect(flash[:error]).to eq(t('errors.doc_auth.phone_step_incomplete'))
         end
       end
     end