Skip to content

LG-10586: Direct users to new SSN entry URL for in-person proofing #9078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NavaTim merged 2 commits into from
Aug 24, 2023
Merged

LG-10586: Direct users to new SSN entry URL for in-person proofing #9078

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6fe1d70
LG-10586: Direct users to new SSN entry URL for in-person proofing
NavaTim Aug 23, 2023
fe5f0e2
LG-10586: Add redirects to previous in-person SSN routes
NavaTim Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/controllers/idv/in_person/verify_info_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def invalid_state?
end

def prev_url
idv_in_person_proofing_ssn_url
idv_in_person_ssn_url
end

def pii
Expand Down
2 changes: 1 addition & 1 deletion app/controllers/idv/in_person_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ class InPersonController < ApplicationController

FLOW_STATE_MACHINE_SETTINGS = {
step_url: :idv_in_person_step_url,
final_url: :idv_in_person_proofing_ssn_url,
final_url: :idv_in_person_ssn_url,
flow: Idv::Flows::InPersonFlow,
analytics_id: 'In Person Proofing',
}.freeze
Expand Down
2 changes: 1 addition & 1 deletion app/services/idv/steps/in_person/address_step.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def call

redirect_to idv_in_person_verify_info_url if updating_address?

redirect_to idv_in_person_proofing_ssn_url
redirect_to idv_in_person_ssn_url
end

def extra_view_variables
Expand Down
2 changes: 1 addition & 1 deletion app/services/idv/steps/in_person/state_id_step.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def call
if pii_from_user[:same_address_as_id] == 'true'
copy_state_id_address_to_residential_address(pii_from_user)
mark_step_complete(:address)
redirect_to idv_in_person_proofing_ssn_url
redirect_to idv_in_person_ssn_url
end

if initial_state_of_same_address_as_id == 'true' &&
Expand Down
2 changes: 1 addition & 1 deletion app/views/idv/in_person/verify_info/show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ locals:
<div class='grid-auto'>
<%= link_to(
t('idv.buttons.change_label'),
idv_in_person_proofing_ssn_url,
idv_in_person_ssn_url,
'aria-label': t('idv.buttons.change_ssn_label'),
) %>
</div>
Expand Down
12 changes: 10 additions & 2 deletions config/routes.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,15 +375,23 @@
# sometimes underscores get messed up when linked to via SMS
as: :capture_doc_dashes

get '/in_person_proofing/ssn' => 'in_person/ssn#show'
put '/in_person_proofing/ssn' => 'in_person/ssn#update'
# DEPRECATION NOTICE
Copy link
Copy Markdown
Contributor

@aduth aduth Aug 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NavaTim Can these be removed now, since these changes have been deployed in production?

Copy link
Copy Markdown
Contributor Author

@NavaTim NavaTim Aug 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the deprecated routes can be removed.

Copy link
Copy Markdown
Contributor

@aduth aduth Sep 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NavaTim Can you take care of cleaning them up? Or is this captured in a ticket somewhere?

Copy link
Copy Markdown
Contributor Author

@NavaTim NavaTim Sep 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Work on the FSM is being deprioritized for the moment, but I can make sure this is captured in a ticket.

# Usage of the /in_person_proofing/ssn routes is deprecated.
# Use the /in_person/ssn routes instead.
#
# These have been left in temporarily to prevent any impact to users
# during the deprecation process.
get '/in_person_proofing/ssn' => redirect('/verify/in_person/ssn', status: 307)
put '/in_person_proofing/ssn' => redirect('/verify/in_person/ssn', status: 307)

get '/in_person' => 'in_person#index'
get '/in_person/ready_to_verify' => 'in_person/ready_to_verify#show',
as: :in_person_ready_to_verify
post '/in_person/usps_locations' => 'in_person/usps_locations#index'
put '/in_person/usps_locations' => 'in_person/usps_locations#update'
post '/in_person/addresses' => 'in_person/address_search#index'
get '/in_person/ssn' => 'in_person/ssn#show'
put '/in_person/ssn' => 'in_person/ssn#update'
get '/in_person/verify_info' => 'in_person/verify_info#show'
put '/in_person/verify_info' => 'in_person/verify_info#update'
get '/in_person/:step' => 'in_person#show', as: :in_person_step
Expand Down
2 changes: 1 addition & 1 deletion spec/controllers/idv/in_person_controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@
it 'finishes the flow' do
put :update, params: { step: 'state_id' }

expect(response).to redirect_to idv_in_person_proofing_ssn_url
expect(response).to redirect_to idv_in_person_ssn_url
end
end
end
Expand Down
4 changes: 2 additions & 2 deletions spec/features/idv/in_person_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,7 +559,7 @@
click_idv_continue

# ssn page
expect(page).to have_current_path(idv_in_person_proofing_ssn_url)
expect(page).to have_current_path(idv_in_person_ssn_url)
complete_ssn_step

# verify page
Expand Down Expand Up @@ -652,7 +652,7 @@
fill_in t('idv.form.address2_optional'), with: InPersonHelper::GOOD_ADDRESS2
fill_in t('idv.form.city'), with: InPersonHelper::GOOD_CITY
click_idv_continue
expect(page).to have_current_path(idv_in_person_proofing_ssn_url, wait: 10)
expect(page).to have_current_path(idv_in_person_ssn_url, wait: 10)
end
end
end
Expand Down
2 changes: 1 addition & 1 deletion spec/features/idv/steps/in_person/state_id_step_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
fill_in t('in_person_proofing.form.state_id.zipcode'), with: '123456789'
expect(page).to have_field(t('in_person_proofing.form.state_id.zipcode'), with: '12345-6789')
click_idv_continue
expect(page).to have_current_path(idv_in_person_proofing_ssn_url)
expect(page).to have_current_path(idv_in_person_ssn_url)
end
end
end