Skip to content

LG-10518: Delete capture troubleshooting component and update tests #9017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
night-jellyfish merged 11 commits into from
Aug 18, 2023
Merged

LG-10518: Delete capture troubleshooting component and update tests #9017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ff6d111
Test that after max retries, see expected heading
Aug 14, 2023
e4a885d
Rm CaptureTroubleshooting and CaptureAdvice
Aug 15, 2023
e63223f
Rm places calling CaptureTroubleshooting
Aug 15, 2023
1bf9f4c
Rm config
Aug 15, 2023
8953b5f
Rm troubleshooting tips copy
Aug 15, 2023
cc17845
changelog: Internal, Doc Auth, Delete CaptureTroubleshooting Componen…
Aug 16, 2023
e383b31
Remove unused var found by CI
Aug 16, 2023
043e5ea
Add allow_browser_log back into test
Aug 16, 2023
54899c5
Rm unused svg files
Aug 16, 2023
4922146
Use fragment instead of div
Aug 16, 2023
3bf8136
Delete redundant test
Aug 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/assets/images/idv/capture-tips-clean.svg
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion app/assets/images/idv/capture-tips-lighting.svg
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion app/assets/images/idv/capture-tips-surface.svg
View file
Open in desktop

This file was deleted.

77 changes: 0 additions & 77 deletions app/javascript/packages/document-capture/components/capture-advice.jsx
View file
Open in desktop

This file was deleted.

55 changes: 0 additions & 55 deletions app/javascript/packages/document-capture/components/capture-troubleshooting.jsx
View file
Open in desktop

This file was deleted.

5 changes: 2 additions & 3 deletions app/javascript/packages/document-capture/components/documents-step.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import HybridDocCaptureWarning from './hybrid-doc-capture-warning';
import DocumentSideAcuantCapture from './document-side-acuant-capture';
import DeviceContext from '../context/device';
import UploadContext from '../context/upload';
import CaptureTroubleshooting from './capture-troubleshooting';
import DocumentCaptureTroubleshootingOptions from './document-capture-troubleshooting-options';
import TipList from './tip-list';

Expand Down Expand Up @@ -47,7 +46,7 @@ function DocumentsStep({
const { flowPath } = useContext(UploadContext);

return (
<CaptureTroubleshooting>
<>
{flowPath === 'hybrid' && <HybridDocCaptureWarning className="margin-bottom-4" />}
<PageHeading>{t('doc_auth.headings.document_capture')}</PageHeading>
<p>{t('doc_auth.info.document_capture_intro_acknowledgment')}</p>
Expand All @@ -73,7 +72,7 @@ function DocumentsStep({
{isLastStep ? <FormStepsButton.Submit /> : <FormStepsButton.Continue />}
<DocumentCaptureTroubleshootingOptions />
<Cancel />
</CaptureTroubleshooting>
</>
);
}

Expand Down
8 changes: 0 additions & 8 deletions app/javascript/packages/document-capture/context/failed-capture-attempts.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,6 @@ interface FailedCaptureAttemptsContextInterface {
*/
onFailedSubmissionAttempt: () => void;

/**
* Number of failed attempts before showing tips
*/
maxFailedAttemptsBeforeTips: number;
/**
* The maximum number of failed Acuant capture attempts
* before use of the native camera option is triggered
Expand Down Expand Up @@ -78,7 +74,6 @@ const FailedCaptureAttemptsContext = createContext<FailedCaptureAttemptsContextI
onResetFailedCaptureAttempts: () => {},
maxCaptureAttemptsBeforeNativeCamera: Infinity,
maxSubmissionAttemptsBeforeNativeCamera: Infinity,
maxFailedAttemptsBeforeTips: Infinity,
lastAttemptMetadata: DEFAULT_LAST_ATTEMPT_METADATA,
forceNativeCamera: false,
});
Expand All @@ -87,14 +82,12 @@ FailedCaptureAttemptsContext.displayName = 'FailedCaptureAttemptsContext';

interface FailedCaptureAttemptsContextProviderProps {
children: ReactNode;
maxFailedAttemptsBeforeTips: number;
maxCaptureAttemptsBeforeNativeCamera: number;
maxSubmissionAttemptsBeforeNativeCamera: number;
}

function FailedCaptureAttemptsContextProvider({
children,
maxFailedAttemptsBeforeTips,
maxCaptureAttemptsBeforeNativeCamera,
maxSubmissionAttemptsBeforeNativeCamera,
}: FailedCaptureAttemptsContextProviderProps) {
Expand Down Expand Up @@ -128,7 +121,6 @@ function FailedCaptureAttemptsContextProvider({
onFailedSubmissionAttempt,
maxCaptureAttemptsBeforeNativeCamera,
maxSubmissionAttemptsBeforeNativeCamera,
maxFailedAttemptsBeforeTips,
lastAttemptMetadata,
forceNativeCamera,
}}
Expand Down
3 changes: 0 additions & 3 deletions app/javascript/packs/document-capture.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ import type { FlowPath, DeviceContextValue } from '@18f/identity-document-captur
*/
interface AppRootData {
helpCenterRedirectUrl: string;
maxCaptureAttemptsBeforeTips: string;
maxAttemptsBeforeNativeCamera: string;
acuantSdkUpgradeABTestingEnabled: string;
useAlternateSdk: string;
Expand Down Expand Up @@ -72,7 +71,6 @@ const formData: Record<string, any> = {

const {
helpCenterRedirectUrl: helpCenterRedirectURL,
maxCaptureAttemptsBeforeTips,
maxCaptureAttemptsBeforeNativeCamera,
maxSubmissionAttemptsBeforeNativeCamera,
acuantVersion,
Expand Down Expand Up @@ -142,7 +140,6 @@ const App = composeComponents(
[
FailedCaptureAttemptsContextProvider,
{
maxFailedAttemptsBeforeTips: Number(maxCaptureAttemptsBeforeTips),
maxCaptureAttemptsBeforeNativeCamera: Number(maxCaptureAttemptsBeforeNativeCamera),
maxSubmissionAttemptsBeforeNativeCamera: Number(maxSubmissionAttemptsBeforeNativeCamera),
},
Expand Down
1 change: 0 additions & 1 deletion app/views/idv/shared/_document_capture.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
glare_threshold: IdentityConfig.store.doc_auth_client_glare_threshold,
sharpness_threshold: IdentityConfig.store.doc_auth_client_sharpness_threshold,
status_poll_interval_ms: IdentityConfig.store.poll_rate_for_verify_in_seconds * 1000,
max_capture_attempts_before_tips: IdentityConfig.store.doc_auth_max_capture_attempts_before_tips,
max_capture_attempts_before_native_camera: IdentityConfig.store.doc_auth_max_capture_attempts_before_native_camera,
max_submission_attempts_before_native_camera: IdentityConfig.store.doc_auth_max_submission_attempts_before_native_camera,
acuant_sdk_upgrade_a_b_testing_enabled: acuant_sdk_upgrade_a_b_testing_enabled,
Expand Down
Loading