Skip to content

Add DELETE route for session logout#6436

Merged
mitchellhenke merged 1 commit intomainfrom
mitchellhenke/delete-logout
Jun 1, 2022
Merged

Add DELETE route for session logout#6436
mitchellhenke merged 1 commit intomainfrom
mitchellhenke/delete-logout

Conversation

@mitchellhenke
Copy link
Contributor

Relevant Slack thread where the issue was raised that a destructive action should probably not be behind a GET route

To softly deprecate the GET route and keep backwards compatibility, this PR only adds the route. The next set of changes can switch existing references within Login.gov.

changelog: Improvements, Session Management, Add support for logging out via DELETE HTTP method
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mitchellhenke mitchellhenke merged commit 12bc280 into main Jun 1, 2022
@mitchellhenke mitchellhenke deleted the mitchellhenke/delete-logout branch June 1, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants