LG-10402: Finish renaming skip_upload_step#8897
Merged
Conversation
Base automatically changed from
matthinz/10402-start-renaming-skip-upload-step
to
main
July 28, 2023 21:49
matthinz
force-pushed
the
matthinz/10402-finish-renaming-skip-upload-step
branch
2 times, most recently
from
afc8cda to
8730805
Compare
soniaconnolly
approved these changes
Aug 1, 2023
Contributor
soniaconnolly
left a comment
soniaconnolly
left a comment
There was a problem hiding this comment.
LGTM
I found one comment in analytics_events that needs updating.
And, I put this in the ticket but you could decide it needs a separate ticket/PR: in hybrid_handoff show template change the cancel step: from upload to hybrid_handoff.
This value is now stored in idv_session.skip_hybrid_handoff [skip changelog]
Contributor
Author
|
Cool, it looks like we don't have any dashboard referencing a |
matthinz
force-pushed
the
matthinz/10402-finish-renaming-skip-upload-step
branch
from
8730805 to
e88ad79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#8894 started writing
skip_hybrid_handofftoIdvSessionalongsideflow_session[:skip_upload_step]. This PR removes references toflow_session[:skip_upload_step]. It will be safe to merge once #8894 has been deployed.🎫 Ticket
LG-10402