LG-10402: Start renaming skip_upload_step#8894
Merged
Conversation
We no longer trigger this event if hybrid handoff is skipped, so it is redundant.
This will take the place of flow_session[:skip_upload_step]. [skip changelog]
params[:type] is set, we can just read that.
The hybrid flow controller should be able to skip the user past if it has been disabled--don't disable it for the entire session right at the beginning.
The HybridHandoffController can detect when hybrid flow is unavailable and redirect accordingly.
matthinz
commented
Jul 28, 2023
| end | ||
|
|
||
| def update | ||
| flow_session[:skip_upload_step] = true unless FeatureManagement.idv_allow_hybrid_flow? |
Contributor
Author
There was a problem hiding this comment.
This logic has moved to HybridHandoffController, which will redirect straight to document capture if the hybrid flow is unavailable.
matthinz
commented
Jul 28, 2023
| def redirect_for_gpo_only | ||
| return redirect_to vendor_outage_url unless FeatureManagement.gpo_verification_enabled? | ||
|
|
||
| # During a phone outage, skip the hybrid handoff |
Contributor
Author
There was a problem hiding this comment.
This logic has moved to HybridHandoffController, which will redirect straight to document capture if the hybrid flow is unavailable.
matthinz
commented
Jul 28, 2023
| end | ||
|
|
||
| def update | ||
| flow_session[:skip_upload_step] = true unless FeatureManagement.idv_allow_hybrid_flow? |
Contributor
Author
There was a problem hiding this comment.
This logic has moved to HybridHandoffController, which will redirect straight to document capture if the hybrid flow is unavailable.
soniaconnolly
approved these changes
Jul 28, 2023
Contributor
soniaconnolly
left a comment
soniaconnolly
left a comment
There was a problem hiding this comment.
LGTM. I had to study the changes to confirm_hybrid_handoff_needed for a while, but the specs agree that it works.
Comment on lines
+209
to
+210
| # But don't store that we skipped it in idv_session, in case it is back to | ||
| # available when the user tries to redo document capture. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10402
🛠 Summary of changes
TLDR: Start writing
idv_session.skip_hybrid_handoffwhen we skip the user past the hybrid handoff step because they're on a mobile device with a camera.Background
When we detect the user is on a mobile device with a built-in camera, we skip the "hybrid handoff" step of IdV. We have to record that the user has skipped hybrid handoff in case they redo document capture (which they can do from the "Verify info" step when their document had a barcode read error).
If the user tries to redo document capture, we want them to skip hybrid handoff again only if they did previously--a desktop user may want to try a different path through document capture.
Up to now, we've recorded that the user skipped hybrid handoff in
flow_session[:skip_upload_step]. There are two problems with this:flow_sessionis an artifact of the flow state machine, which is now in the past. We have another "session",IdvSessionthat we use to store data about the user's in-progress IdV attempt.So this PR adds a new key to
IdvSession,skip_hybrid_handoff, and starts writing it alongsideflow_session[:skip_upload_step]. A future PR will remove references to:skip_upload_stepafter this change has been deployed.