LG-10402: Finish renaming skip_upload_step

app/controllers/idv/agreement_controller.rb

@@ -46,7 +46,6 @@ def analytics_arguments
     end
 
     def skip_to_capture
-      flow_session[:skip_upload_step] = true
       idv_session.flow_path = 'standard'
 
       # Store that we're skipping hybrid handoff so if the user

app/controllers/idv/getting_started_controller.rb

@@ -65,7 +65,6 @@ def cancel_previous_in_person_enrollments
     end
 
     def skip_to_capture
-      flow_session[:skip_upload_step] = true
       idv_session.flow_path = 'standard'
 
       # Store that we're skipping hybrid handoff so if the user

app/controllers/idv/hybrid_handoff_controller.rb

@@ -199,9 +199,6 @@ def confirm_hybrid_handoff_needed
       if idv_session.skip_hybrid_handoff?
         # We previously skipped hybrid handoff. Keep doing that.
         idv_session.flow_path = 'standard'
-      elsif flow_session[:skip_upload_step]
-        # TEMP: Will be removing :skip_upload_step in future commit
-        idv_session.flow_path = 'standard'
       end
 
       if !FeatureManagement.idv_allow_hybrid_flow?
@@ -224,9 +221,7 @@ def setup_for_redo
       # If we previously skipped hybrid handoff for the user (because they're on a mobile
       # device with a camera), skip it _again_ here.
 
-      if flow_session[:skip_upload_step]
-        idv_session.flow_path = 'standard'
-      elsif idv_session.skip_hybrid_handoff?
+      if idv_session.skip_hybrid_handoff?
         idv_session.flow_path = 'standard'
       else
         idv_session.flow_path = nil

app/services/analytics_events.rb

@@ -644,7 +644,7 @@ def idv_consent_checkbox_toggled(checked:, **extra)
   end
 
   # User has consented to share information with document upload and may
-  # view the "hybrid handoff" step next unless "skip_upload" param is true
+  # view the "hybrid handoff" step next unless "skip_hybrid_handoff" param is true
   def idv_doc_auth_agreement_submitted(**extra)
     track_event('IdV: doc auth agreement submitted', **extra)
   end

app/views/idv/hybrid_handoff/show.html.erb

@@ -80,4 +80,4 @@
   </div>
 </div>
 
-<%= render 'idv/doc_auth/cancel', step: 'upload' %>
+<%= render 'idv/doc_auth/cancel', step: 'hybrid_handoff' %>

spec/controllers/idv/agreement_controller_spec.rb

@@ -137,14 +137,6 @@
         }.from(nil).to('standard')
       end
 
-      it 'sets flow_session[:skip_upload_step] to true' do
-        expect do
-          put :update, params: params
-        end.to change {
-          subject.flow_session[:skip_upload_step]
-        }.from(nil).to(true)
-      end
-
       it 'redirects to hybrid handoff' do
         put :update, params: params
         expect(response).to redirect_to(idv_hybrid_handoff_url)

spec/controllers/idv/getting_started_controller_spec.rb

@@ -164,14 +164,6 @@
         }.from(nil).to('standard')
       end
 
-      it 'sets flow_session[:skip_upload_step] to true' do
-        expect do
-          put :update, params: params
-        end.to change {
-          subject.flow_session[:skip_upload_step]
-        }.from(nil).to(true)
-      end
-
       it 'redirects to hybrid handoff' do
         put :update, params: params
         expect(response).to redirect_to(idv_hybrid_handoff_url)

spec/controllers/idv/hybrid_handoff_controller_spec.rb

@@ -125,18 +125,6 @@
         expect(response).to render_template :show
       end
 
-      context 'skip_upload_step is set on flow_session' do
-        before do
-          subject.user_session['idv/doc_auth'][:skip_upload_step] = true
-        end
-        it 'redirects to document_capture' do
-          subject.idv_session.flow_path = 'standard'
-          get :show, params: { redo: true }
-
-          expect(response).to redirect_to(idv_document_capture_url)
-        end
-      end
-
       context 'idv_session.skip_hybrid_handoff? is true' do
         before do
           subject.idv_session.skip_hybrid_handoff = true
@@ -166,13 +154,6 @@
         get :show
         expect(response).to redirect_to(idv_document_capture_url)
       end
-      it 'does not set flow_session[:skip_upload_step]' do
-        expect do
-          get :show
-        end.not_to change {
-          subject.flow_session[:skip_upload_step]
-        }.from(nil)
-      end
       it 'does not set idv_session.skip_hybrid_handoff' do
         expect do
           get :show