Skip to content

Exempt "InvalidStateError" from WebAuthn error tracking#8882

Merged
aduth merged 1 commit intomainfrom
aduth-exempt-invalid-state-dom-exception
Jul 27, 2023
Merged

Exempt "InvalidStateError" from WebAuthn error tracking#8882
aduth merged 1 commit intomainfrom
aduth-exempt-invalid-state-dom-exception

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Jul 27, 2023

🎫 Ticket

Addendum for LG-10457

🛠 Summary of changes

Revises the exception set for allowable errors introduced in #8859's error tracking to also allow InvalidStateError. After testing this in a live environment, it was observed that InvalidStateError frequently may occur when a user attempts to enroll an authenticator that's already been registered.

📜 Testing Plan

  1. Create an account with security key
  2. Add a security key from account dashboard
  3. In browser DevTools console, add a breakpoint at
    (globalThis as typeof globalThis & NewRelicGlobals).newrelic?.noticeError(error);
  4. Assuming it's the same security key, observe breakpoint is not triggered

changelog: Upcoming Features, Face or Touch Unlock, Log unexpected errors during WebAuthn enrollment or authentication
@aduth aduth merged commit 090b233 into main Jul 27, 2023
@aduth aduth deleted the aduth-exempt-invalid-state-dom-exception branch July 27, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants