Skip to content

Exempt "InvalidStateError" from WebAuthn error tracking #8882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduth merged 1 commit into from
Jul 27, 2023
Merged

Exempt "InvalidStateError" from WebAuthn error tracking #8882

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions app/javascript/packages/webauthn/is-expected-error.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,17 @@
/**
* Set of expected DOM exceptions, which occur based on some user behavior that is not noteworthy,
* such as declining permissions or timeout due to inactivity.
* Set of expected DOM exceptions, which occur based on some user behavior that is not noteworthy:
*
* - Declining permissions
* - Timeout due to inactivity
* - Invalid state such as duplicate key enrollment
*
* @see https://webidl.spec.whatwg.org/#idl-DOMException
*/
const EXPECTED_DOM_EXCEPTIONS: Set<string> = new Set(['NotAllowedError', 'TimeoutError']);
const EXPECTED_DOM_EXCEPTIONS: Set<string> = new Set([
'NotAllowedError',
'TimeoutError',
'InvalidStateError',
]);

const isExpectedWebauthnError = (error: Error): boolean =>
error instanceof DOMException && EXPECTED_DOM_EXCEPTIONS.has(error.name);
Expand Down