LG-10457: Track unexpected WebAuthn errors#8859
Merged
Conversation
changelog: Upcoming Features, Face or Touch Unlock, Log unexpected errors during WebAuthn enrollment or authentication
mitchellhenke
approved these changes
Jul 26, 2023
Contributor
Author
|
I revised the implementation slightly based on the issue reported in #8877 to ensure that the error being thrown there would have been noticed by the error tracking introduced here. The error in Firefox is an This might still end up being too noisy, but we can follow-up to filter out more error types based on what we see in the error tracker. |
mdiarra3
approved these changes
Jul 27, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10457
🛠 Summary of changes
Adds error tracking for "unexpected" errors that occur during WebAuthn enrollment or authentication. An unexpected error is one not occurring as an outcome of the WebAuthn API ceremony, but rather may point to errors in our own code.
See Slack discussion: https://gsa-tts.slack.com/archives/C01710KMYUB/p1690308232479249
📜 Testing Plan
Test expected errors:
Add a breakpoint to
trackError:Create or sign in to an account with Face or Touch Unlock, cancel the ceremony, and observe that the breakpoint is not triggered.
Test unexpected errors:
Keep the above breakpoint, and add some artificial errors:
Create or sign in to an account with Face or Touch Unlock, and observe that the breakpoint is triggered when initiating the WebAuthn ceremony.