Skip to content

LG-10442: Fix required MFA redirect for platform authenticator#8850

Merged
aduth merged 1 commit intomainfrom
aduth-lg-10442-phishing-resistant-required-platform
Jul 27, 2023
Merged

LG-10442: Fix required MFA redirect for platform authenticator#8850
aduth merged 1 commit intomainfrom
aduth-lg-10442-phishing-resistant-required-platform

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Jul 25, 2023

🎫 Ticket

LG-10442

🛠 Summary of changes

Fixes the behavior of the redirect logic for a partner requesting phishing-resistant MFAs to account for a user which has Face or Touch Unlock configured. Previously, the user would be redirected to authenticate with Security Key which, when combined with the changes introduced in #8795, would prevent the user from being able to successfully authenticate.

📜 Testing Plan

  1. Go to http://localhost:3000
  2. Create an account
  3. At MFA setup, select Face or Touch Unlock
    • You can select multiple MFA, but avoid Security Key and PIV as your second MFA method for the purpose of this bug
  4. Complete account creation
  5. Click "Forget all browsers" in account sidebar and confirm prompt
  6. Sign out
  7. With sample RP application running in a separate terminal process, go to http://localhost:9292/?aal=2-phishing_resistant
  8. Click "Sign in"
  9. Sign in to the account created previously

Before: You are prompted for a Security Key, but you cannot complete this step because you don't have a Face/Touch Unlock credential configured.

After: You are prompted for your Face/Touch Unlock credential.

changelog: Upcoming Features, Face or Touch Unlock, Fix required MFA redirect for phishing-resistant-required request
@aduth aduth requested a review from a team July 25, 2023 14:29
@aduth aduth merged commit a3a9cd0 into main Jul 27, 2023
@aduth aduth deleted the aduth-lg-10442-phishing-resistant-required-platform branch July 27, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants