Remove WebAuthn support detection, error page#8764
Merged
Conversation
changelog: Upcoming Features, Face or Touch Unlock, Remove unnecessary feature detection for WebAuthn
aduth
force-pushed
the
aduth-rm-webauthn-not-enabled
branch
from
d331998 to
6e5ba06
Compare
aduth
commented
Jul 13, 2023
| get '/login/two_factor/piv_cac' => 'two_factor_authentication/piv_cac_verification#show' | ||
| get '/login/two_factor/piv_cac/present_piv_cac' => 'two_factor_authentication/piv_cac_verification#redirect_to_piv_cac_service' | ||
| get '/login/two_factor/webauthn' => 'two_factor_authentication/webauthn_verification#show' | ||
| get '/login/two_factor/webauthn_error' => 'two_factor_authentication/webauthn_verification#error' |
Contributor
Author
There was a problem hiding this comment.
Maybe should have removed this in a separate deployment, to avoid 50/50 issues. Pretty low risk though, since this error would only be seen by people using unsupported browsers. I'll check the logs.
Contributor
Author
There was a problem hiding this comment.
After checking logs, there's some traffic to this page still, but reasonably low overall.
Also worth noting the actual experience for someone on an unsupported browser should be marginally improved by these changes, since they'll still see an error message when trying to authenticate. Unlike before, they'll now have the option to select another MFA method on the unsupported device, which was not possible previously.
This was referenced Jul 13, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Removes all logic associated with checking the user browser for WebAuthn support, based on the assumption that our browser support commitments are such that WebAuthn would be expected to be available in all supported browsers.
https://developer.mozilla.org/en-US/docs/Web/API/Navigator/credentials#browser_compatibility
📜 Testing Plan
Verify no regressions in signing in and MFA'ing to an account with a Security Key or Face or Touch Unlock configured.