Merged
Conversation
Upon redirect from the Socure CaptureApp, we load the result stored in the DocumentCaptureSession, and if successful, redirect to the SSN entry step. switch callback to a GET changelog: Upcoming Features, Identity Verification, Handle Socure handoff. Co-authored-by: John Maxwell <john.maxwell@gsa.gov>
theabrad
approved these changes
Nov 6, 2024
Contributor
theabrad
left a comment
theabrad
left a comment
There was a problem hiding this comment.
LGTM tested it in your environment and worked as expected.
amirbey
reviewed
Nov 6, 2024
amirbey
reviewed
Nov 6, 2024
amirbey
reviewed
Nov 6, 2024
spec/controllers/idv/socure/document_capture_controller_spec.rb
Outdated
Show resolved
Hide resolved
amirbey
reviewed
Nov 6, 2024
amirbey
reviewed
Nov 8, 2024
spec/controllers/idv/socure/document_capture_controller_spec.rb
Outdated
Show resolved
Hide resolved
amirbey
reviewed
Nov 8, 2024
| Funnel::DocAuth::RegisterStep.new(current_user.id, sp_session[:issuer]). | ||
| call('socure_document_capture', :update, true) | ||
|
|
||
| # cancel_establishing_in_person_enrollments |
solipet
force-pushed
the
dprice/lg-14007-handle-redirect-from-socure
branch
from
eee8645 to
f0a49ba
Compare
amirbey
approved these changes
Nov 8, 2024
Contributor
amirbey
left a comment
amirbey
left a comment
There was a problem hiding this comment.
PR 1 of 2 ... LGTM 👍🏿
PR for async result to come 😄
…l from socure doc cap controller
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-14007
🛠 Summary of changes
Added a new GET route for the socure callback and pass that in on the request for the document capture app url. Upon receiving that GET, we collect the results from the DocumentCaptureSession, then if successful, redirect to the SSN step.
If not successful, it currently redirects back to the socure document capture page.
📜 Testing Plan
Currently deployed to a test environment:
/verify