Add word-wrap security advisory to audit allowlist#8679
Merged
Conversation
changelog: Internal, Dependencies, Address security advisories
mitchellhenke
approved these changes
Jun 28, 2023
jmax-gsa
approved these changes
Jun 28, 2023
Contributor
jmax-gsa
left a comment
jmax-gsa
left a comment
There was a problem hiding this comment.
LGTM, as a temporary expedient.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Resolves security advisory notices affecting all builds on
main, related to a a security advisory in theword-wrapdependency.This is a temporary alternative to #8677 to allow builds to pass again. #8677 is a viable path forward, but requires more work to address issues with upgrades to the affected packages. This is enforced as temporary with an expiration of August 1.
The risk here is quite low due to how packages operate with
optionator(see related comment gkz/optionator#44 (comment))📜 Testing Plan
The
audit_yarn_packageexits with a successful exit code: