Skip to content

Add exception to sender_id requirement for Australia (AU) #8564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
soniaconnolly merged 4 commits into from
Jun 8, 2023
Merged

Add exception to sender_id requirement for Australia (AU) #8564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fdd1041
Add Australia (AU) to SENDER_ID_COUNTRIES
soniaconnolly Jun 8, 2023
1460e94
Create exception list for sender id countries
soniaconnolly Jun 8, 2023
bea562a
Test our work
soniaconnolly Jun 8, 2023
3a7fbe7
changelog
soniaconnolly Jun 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/pinpoint_supported_countries.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,12 @@ class PinpointSupportedCountries
TH
].to_set.freeze

# Countries where AWS claims sender ID is required, and we don't have one, and
# it seems to work anyway.
SENDER_ID_EXCEPTION_COUNTRIES = %w[
AU
].to_set.freeze

CountrySupport = Struct.new(
:iso_code,
:name,
Expand Down Expand Up @@ -69,7 +75,7 @@ def sms_support
iso_code = sms_config['ISO code']
supports_sms = case trim_spaces(sms_config['Supports Sender IDs'])
when 'Registration required1'
SENDER_ID_COUNTRIES.include?(iso_code)
SENDER_ID_COUNTRIES.include?(iso_code) || SENDER_ID_EXCEPTION_COUNTRIES.include?(iso_code)
when 'Registration required3' # basically only India, has special rules
true
else
Expand Down
13 changes: 12 additions & 1 deletion spec/lib/pinpoint_supported_countries_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,11 +150,22 @@
stub_const('PinpointSupportedCountries::SENDER_ID_COUNTRIES', [])
end

it 'is supported' do
it 'is not supported' do
belarus = countries.sms_support.find { |c| c.iso_code == 'BY' }
expect(belarus.supports_sms).to eq(false)
end
end

context 'when we do not have a sender ID and the country is on our exceptions list' do
before do
stub_const('PinpointSupportedCountries::SENDER_ID_EXCEPTION_COUNTRIES', %w[BY])
end

it 'is supported' do
belarus = countries.sms_support.find { |c| c.iso_code == 'BY' }
expect(belarus.supports_sms).to eq(true)
end
end
end

describe '#voice_support' do
Expand Down