Skip to content

Remove call to document_capture_errors endpoint #8540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthinz merged 1 commit into from
Jun 6, 2023
Merged

Remove call to document_capture_errors endpoint #8540

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 2 additions & 15 deletions app/javascript/packages/document-capture/components/barcode-attention-warning.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,11 @@
import { useContext } from 'react';
import { Button, StatusPage } from '@18f/identity-components';
import { SpinnerButton } from '@18f/identity-spinner-button';
import { t } from '@18f/identity-i18n';
import { trackEvent } from '@18f/identity-analytics';
import { removeUnloadProtection } from '@18f/identity-url';
import UploadContext from '../context/upload';
import { toFormData } from '../services/upload';
import type { PII } from '../services/upload';
import DocumentCaptureTroubleshootingOptions from './document-capture-troubleshooting-options';

const DOCUMENT_CAPTURE_ERRORS_API_URL = '/api/verify/v2/document_capture_errors';

interface BarcodeAttentionWarningProps {
/**
* Callback to trigger when user opts to try to take new photos rather than continue to next step.
Expand All @@ -24,16 +19,8 @@ interface BarcodeAttentionWarningProps {
}

function BarcodeAttentionWarning({ onDismiss, pii }: BarcodeAttentionWarningProps) {
const { formData } = useContext(UploadContext);

async function skipAttention() {
await Promise.all([
trackEvent('IdV: barcode warning continue clicked'),
window.fetch(DOCUMENT_CAPTURE_ERRORS_API_URL, {
method: 'DELETE',
body: toFormData({ document_capture_session_uuid: formData.document_capture_session_uuid }),
}),
]);
function skipAttention() {
trackEvent('IdV: barcode warning continue clicked');
Copy link
Contributor Author

@matthinz matthinz Jun 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(trackEvent is no longer async, so this whole function can be made non-async)

Copy link
Contributor

@aduth aduth Jun 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also make the SpinnerButton that calls it a regular Button now as well, @matthinz ?

Copy link
Contributor Author

@matthinz matthinz Jun 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing, I'll follow up with a new PR

removeUnloadProtection();
const form = document.querySelector<HTMLFormElement>('.js-document-capture-form');
form?.submit();
Expand Down