Only use postgis adapter for primary database#8914
Merged
mitchellhenke merged 1 commit intomainfrom Aug 2, 2023
Merged
Conversation
changelog: Internal, Database, Only use postgis adapter for primary database
tomas-nava
approved these changes
Aug 2, 2023
Contributor
tomas-nava
left a comment
tomas-nava
left a comment
There was a problem hiding this comment.
I didn't sandbox test, but the change looks fine to me
mitchellhenke
deleted the
mitchellhenke/use-postgis-adapter-only-for-primary
branch
| adapter: postgis | ||
| replica: true | ||
| worker_jobs: | ||
| <<: *test |
Contributor
There was a problem hiding this comment.
Hmm... this spreads the "primary" entry, which looks like it's aliased as test... and test specifies the postgis adapter. Is that right? Everywhere else it looks like we prefer postgresql adapter for the worker_jobs entry...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
We've been seeing some odd connection errors connecting to the worker database since #8536 (NewRelic). The major change was postgis adapter for connections to all databases, but since the worker database does not have
postgisor use it, this PR changes it so the default connection ispostgresqland thepostgisdatabases override the `adapter.This was tested in my sandbox.