Skip to content

LG-10011: Redirect to MFA selection page#9749

Merged
mdiarra3 merged 4 commits intomainfrom
LG-10011-redirect-new-mfa-legacy
Dec 19, 2023
Merged

LG-10011: Redirect to MFA selection page#9749
mdiarra3 merged 4 commits intomainfrom
LG-10011-redirect-new-mfa-legacy

Conversation

@mdiarra3
Copy link
Contributor

@mdiarra3 mdiarra3 commented Dec 12, 2023

🎫 Ticket

LG-10011

🛠 Summary of changes

This will redirect users to MFA selection page on using the personal key. Content needs to be updated

@mdiarra3 mdiarra3 requested a review from a team December 12, 2023 19:49
@mdiarra3 mdiarra3 marked this pull request as ready for review December 14, 2023 14:25
@aduth
Copy link
Contributor

aduth commented Dec 15, 2023

Since legacy personal key MFA is not available for new accounts, I think it'd be helpful to include testing instructions. #8531 might be an example to draw from, or ideally there's an easier way to set this up.

@aduth
Copy link
Contributor

aduth commented Dec 15, 2023

#8531 might be an example to draw from, or ideally there's an easier way to set this up.

Actually, I found a much easier way, based on the specs for this controller:

In rails console:

# replace email for local user
PersonalKeyGenerator.new(User.find_with_email('email@example.com')).create

(which prints out the generated personal key)

Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM 👍

@mdiarra3 mdiarra3 merged commit f0a36f4 into main Dec 19, 2023
@mdiarra3 mdiarra3 deleted the LG-10011-redirect-new-mfa-legacy branch December 19, 2023 14:33
@jmdembe jmdembe mentioned this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants