Skip to content

LG-9860: Fix platform authenticator reauthentication redirect #8490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduth merged 2 commits into from
May 26, 2023
Merged

LG-9860: Fix platform authenticator reauthentication redirect #8490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44078f3
LG-9860: Fix platform authenticator reauthentication redirect
aduth May 26, 2023
cd97484
Omit platform parameter if false
aduth May 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/views/users/webauthn_setup/new.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

<%= simple_form_for(
'',
url: webauthn_setup_path,
url: webauthn_setup_path(platform: @platform_authenticator.presence),
method: :patch,
html: {
class: 'margin-top-4 margin-bottom-1',
Expand Down
11 changes: 11 additions & 0 deletions spec/features/webauthn/management_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,17 @@ def expect_webauthn_platform_setup_error

expect(page).to have_current_path webauthn_setup_path(platform: true)

# Regression: LG-9860: Ensure that the platform URL parameter is maintained through reauthn
travel_to (IdentityConfig.store.reauthn_window + 1).seconds.from_now
fill_in_nickname_and_click_continue
mock_press_button_on_hardware_key_on_setup

expect(page).to have_current_path login_two_factor_options_path(reauthn: true)
click_on t('forms.buttons.continue')
fill_in_code_with_last_phone_otp
click_submit_default

expect(page).to have_current_path webauthn_setup_path(platform: true)
fill_in_nickname_and_click_continue
mock_press_button_on_hardware_key_on_setup

Expand Down