Skip to content

LG-9423: Radio buttons are not read correctly by assistive technology when reading with the arrow keys #8487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmdembe merged 5 commits into from
May 26, 2023
Merged

LG-9423: Radio buttons are not read correctly by assistive technology when reading with the arrow keys #8487

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
73d97aa
can I add lang as attribute on label?
jmdembe May 22, 2023
da7e9b9
add `lang` attribute to inputs
jmdembe May 24, 2023
4b7ddfb
add lang attribute for span again
jmdembe May 25, 2023
79386eb
Merge branch 'main' into LG-9423-radio-button-lang-announcement
jmdembe May 25, 2023
e322fb6
changelog: Improvements, accessibility, input not reading in correct …
jmdembe May 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/views/shared/_email_languages.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ locals:
),
locale,
checked: selection ? selection.to_s == locale.to_s : I18n.locale.to_s == locale.to_s,
lang: locale,

@aduth aduth May 25, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have lang above on line 28 as well. Do we need both?

@jmdembe jmdembe May 25, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 32 puts the attribute on the element while 28 puts it on the <span> attribute itself. Right now, if a user activates the read-all feature, it will read both the input and the text in the set languages.

The fact that this is happening should be discussed further and that is why I wrote LG-9949. There have been previous discussions on whether or not similar behaviors are priority fixes. So for now, I think we both.

]
end,
) %>