LG-5456: Implement confirmation tooltip for clipboard button#8307
Merged
LG-5456: Implement confirmation tooltip for clipboard button#8307
Conversation
mdiarra3
approved these changes
May 1, 2023
Contributor
Author
|
I was planning to rebase this against main to avoid a dependency on #8093, but it looks like the |
changelog: User-Facing Improvements, Copy Button, Add confirmation tooltip to Copy buttons
Hidden elements are valid as references for idref
aduth
force-pushed
the
aduth-clipboard-button-tooltip
branch
from
7c2e24d to
2dcee73
Compare
Contributor
Author
|
I rebased against main now that #8093 is merged. In some final testing on my phone, I spotted an issue in how USWDS implements the tooltip that conflicts with our mobile button display, causing the buttons to no longer appear full-width. I'm going to try to find a workaround, pending an upstream fix.
|
2 tasks
Merged
This was referenced May 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-5456
🛠 Summary of changes
Adds a new tooltip to be shown when activating "Copy" buttons, using the U.S. Web Design System Tooltip component with alterations to display the tooltip only once the button is activated.
For accessibility reasons (SC 2.2.3 No Timing), the tooltip will remain visible as long as the button has focus (or as long as the cursor remains over the button in the case of Safari cursor click, due to intentional browser-specific button mechanics).
Note that this is currently temporarily set to merge to
aduth-lgds-7only because it's expected to land soon and would have conflicts with what's being introduced here. I'll rebase againstmainonce the other branch is merged.📜 Testing Plan
👀 Screenshots