Sign in live in the in person happy path tests#8473
Conversation
|
These tests currently fail and will not pass until #8468 is merged |
jmhooper
force-pushed
the
jmhooper-in-person-sign-in-live
branch
from
556cac5 to
2425467
Compare
The in-person tests were using the `sign_in_user` helper to test that a user sees the screen with their barcode visible. This signs in with Warden which does not run through all of the before actions for signing in. Additionally, when the in person happy path tests were signing in the user was already signed in. This commit addresses both of the above. [skip changelog]
jmhooper
force-pushed
the
jmhooper-in-person-sign-in-live
branch
from
2425467 to
4e07bf6
Compare
|
I have rebased this PR and it is ready for review |
| complete_doc_auth_steps_before_welcome_step | ||
| Capybara.reset_session! | ||
| sign_in_live_with_2fa(user) | ||
| expect(page).to have_current_path(idv_in_person_ready_to_verify_path) |
There was a problem hiding this comment.
IIRC they should only see the "ready to verify" screen if they're going through IdV again, such as through a partner request. Would that not be reset via reset_session! ? 🤔
There was a problem hiding this comment.
This is after they've registered but before they've visited the Post Office, so they still have a pending enrollment. In that case, we expect them to see the 'ready to verify' screen
There was a problem hiding this comment.
Even when signing in from the root sign-in page, not associated with a specific service provider IdV request? How do they manage account settings then?
There was a problem hiding this comment.
This currently matches the behavior for password reset of GPO pending:
- Users signing in for auth only get redirected to the SP
- Users signing in for IdV get the ready to verify page
- Users signing in without an SP get the ready to verify page
There was a problem hiding this comment.
This does seems like a good point though, @aduth. Unlike the password reset or GPO page, the ready to verify page does not include a link back to the profile.
3 participants
The in-person tests were using the
sign_in_userhelper to test that a user sees the screen with their barcode visible. This signs in with Warden which does not run through all of the before actions for signing in.Additionally, when the in person happy path tests were signing in the user was already signed in.
This commit addresses both of the above.