Conversation
Contributor
Author
|
This is still work in progress. There is a lot of work left to sort out the SAML and OIDC controllers. |
Contributor
Author
|
Okay, I think I have the OIDC and SAML controller in shape. This is ready for review. |
mitchellhenke
approved these changes
May 23, 2023
Contributor
There was a problem hiding this comment.
Is it worth trying to move away from the generic "has pending profile"? If we wanted to, we could take a small shortcut and replace the conditionals used with:
Suggested change
| return url_for_pending_profile_reason if user_has_pending_profile? | |
| return url_for_pending_profile_reason if url_for_pending_profile_reason |
It looks like the method would still be used by some analytics, but it might be worth splitting that up to be more specific too.
Contributor
There was a problem hiding this comment.
Much easier to read 😀
Base automatically changed from
jmhooper-untangle-backup-code-reminder-from-pending-profile
to
main
May 24, 2023 15:15
…ser may be pending We have made changes to the `pending_profile` concept in the IdP. Previously a profile was pending if the user was waiting on GPO verification. We have added more out of band flows which result in more pending reasons: 1. GPO Verification 2. Fraud review 3. In-person proofing This logic got spread throughout the codebase in ways that were often kind of tough to follow. This led to lots of bugs trying to send the user to the right place to finish proofing. This commit collects that logic in the `VerifyProfileConcern`. This was chosen because this is where much of the logic for the GPO confirmation flow lived already. [skip changelog]
jmhooper
force-pushed
the
jmhooper-use-pending-profile-concern
branch
from
578ba63 to
a74354a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have made changes to the
pending_profileconcept in the IdP. Previously a profile was pending if the user was waiting on GPO verification. We have added more out of band flows which result in more pending reasons:This logic got spread throughout the codebase in ways that were often kind of tough to follow. This led to lots of bugs trying to send the user to the right place to finish proofing.
This commit collects that logic in the
VerifyProfileConcern. This was chosen because this is where much of the logic for the GPO confirmation flow lived already.