Skip to content

Sign in live in the in person happy path tests #8473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmhooper merged 2 commits into from
May 30, 2023
Merged

Sign in live in the in person happy path tests #8473

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e07bf6
Sign in live in the in person happy path tests
jmhooper May 23, 2023
b547313
Merge branch 'main' into jmhooper-in-person-sign-in-live
jmhooper May 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions spec/features/idv/in_person_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,8 @@
)

# signing in again before completing in-person proofing at a post office
sign_in_and_2fa_user(user)
complete_doc_auth_steps_before_welcome_step
Capybara.reset_session!
sign_in_live_with_2fa(user)
expect(page).to have_current_path(idv_in_person_ready_to_verify_path)
Copy link
Copy Markdown
Contributor

@aduth aduth May 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC they should only see the "ready to verify" screen if they're going through IdV again, such as through a partner request. Would that not be reset via reset_session! ? 🤔

Copy link
Copy Markdown
Contributor

@tomas-nava tomas-nava May 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is after they've registered but before they've visited the Post Office, so they still have a pending enrollment. In that case, we expect them to see the 'ready to verify' screen

Copy link
Copy Markdown
Contributor

@aduth aduth May 24, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even when signing in from the root sign-in page, not associated with a specific service provider IdV request? How do they manage account settings then?

Copy link
Copy Markdown
Contributor Author

@jmhooper jmhooper May 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This currently matches the behavior for password reset of GPO pending:

  1. Users signing in for auth only get redirected to the SP
  2. Users signing in for IdV get the ready to verify page
  3. Users signing in without an SP get the ready to verify page

Copy link
Copy Markdown
Contributor Author

@jmhooper jmhooper May 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does seems like a good point though, @aduth. Unlike the password reset or GPO page, the ready to verify page does not include a link back to the profile.

Copy link
Copy Markdown
Contributor

@tomas-nava tomas-nava Jun 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we created LG-10119 to address this!

end
end
Expand Down Expand Up @@ -240,8 +240,8 @@
)

# signing in again before completing in-person proofing at a post office
sign_in_and_2fa_user(user)
complete_doc_auth_steps_before_welcome_step
Capybara.reset_session!
sign_in_live_with_2fa(user)
expect(page).to have_current_path(idv_in_person_ready_to_verify_path)

# confirm that user cannot visit other IdV pages before completing in-person proofing
Expand Down