LG-9494 capture complete checks if previous step is done

app/controllers/concerns/idv/hybrid_mobile/hybrid_mobile_concern.rb

@@ -19,6 +19,12 @@ def check_valid_document_capture_session
         return handle_invalid_document_capture_session if document_capture_session.expired?
       end
 
+      def confirm_document_capture_session_complete
+        return if document_capture_session&.load_result&.success?
+
+        redirect_to idv_hybrid_mobile_document_capture_url
+      end
+
       def document_capture_session
         return @document_capture_session if defined?(@document_capture_session)
         @document_capture_session =

app/controllers/idv/document_capture_controller.rb

@@ -28,7 +28,11 @@ def update
       Funnel::DocAuth::RegisterStep.new(current_user.id, sp_session[:issuer]).
         call('document_capture', :update, true)
 
-      redirect_to idv_ssn_url
+      if result.success?
+        redirect_to idv_ssn_url
+      else
+        redirect_to idv_document_capture_url
+      end
     end
 
     def extra_view_variables

app/controllers/idv/hybrid_mobile/capture_complete_controller.rb

@@ -4,6 +4,7 @@ class CaptureCompleteController < ApplicationController
       include HybridMobileConcern
 
       before_action :check_valid_document_capture_session
+      before_action :confirm_document_capture_session_complete
 
       def show
         analytics.idv_doc_auth_capture_complete_visited(**analytics_arguments)

app/controllers/idv/hybrid_mobile/document_capture_controller.rb

@@ -7,6 +7,11 @@ class DocumentCaptureController < ApplicationController
       before_action :override_csp_to_allow_acuant
 
       def show
+        if document_capture_session&.load_result&.success?
+          redirect_to idv_hybrid_mobile_capture_complete_url
+          return
+        end
+
         analytics.idv_doc_auth_document_capture_visited(**analytics_arguments)
 
         Funnel::DocAuth::RegisterStep.new(document_capture_user.id, sp_session[:issuer]).
@@ -23,7 +28,11 @@ def update
         Funnel::DocAuth::RegisterStep.new(document_capture_user.id, sp_session[:issuer]).
           call('document_capture', :update, true)
 
-        redirect_to idv_hybrid_mobile_capture_complete_url
+        if result.success?
+          redirect_to idv_hybrid_mobile_capture_complete_url
+        else
+          redirect_to idv_hybrid_mobile_document_capture_url
+        end
       end
 
       def extra_view_variables

spec/controllers/idv/hybrid_mobile/capture_complete_controller_spec.rb

@@ -25,6 +25,8 @@
   before do
     session[:doc_capture_user_id] = user&.id
     session[:document_capture_session_uuid] = document_capture_session_uuid
+    allow(subject).to receive(:confirm_document_capture_session_complete).
+      and_return(true)
   end
 
   describe 'before_actions' do
@@ -34,6 +36,13 @@
         :check_valid_document_capture_session,
       )
     end
+
+    it 'includes document capture session complete before action' do
+      expect(subject).to have_actions(
+        :before,
+        :confirm_document_capture_session_complete,
+      )
+    end
   end
 
   context 'when doc_auth_hybrid_mobile_controllers_enabled' do

spec/features/idv/hybrid_flow_spec.rb

@@ -9,7 +9,7 @@
 
   before do
     allow(FeatureManagement).to receive(:doc_capture_polling_enabled?).and_return(true)
-    allow(IdentityConfig.store).to receive(:doc_auth_enable_presigned_s3_urls).and_return(true)
+    allow(IdentityConfig.store).to receive(:doc_auth_enable_presigned_s3_urls).and_return(false)
     allow(Identity::Hostdata::EC2).to receive(:load).
       and_return(OpenStruct.new(region: 'us-west-2', account_id: '123456789'))
   end

spec/features/idv/hybrid_mobile/hybrid_mobile_spec.rb

@@ -12,7 +12,7 @@
       and_return(true)
 
     allow(FeatureManagement).to receive(:doc_capture_polling_enabled?).and_return(true)
-    allow(IdentityConfig.store).to receive(:doc_auth_enable_presigned_s3_urls).and_return(true)
+    allow(IdentityConfig.store).to receive(:doc_auth_enable_presigned_s3_urls).and_return(false)
     allow(Identity::Hostdata::EC2).to receive(:load).
       and_return(OpenStruct.new(region: 'us-west-2', account_id: '123456789'))
   end
@@ -40,12 +40,21 @@
 
     perform_in_browser(:mobile) do
       visit @sms_link
+
+      # Confirm app disallows jumping ahead to CaptureComplete page
+      visit idv_hybrid_mobile_capture_complete_url
+      expect(page).to have_current_path(idv_hybrid_mobile_document_capture_url)
+
       attach_and_submit_images
 
       expect(page).to have_current_path(idv_hybrid_mobile_capture_complete_url)
       expect(page).to have_content(t('doc_auth.headings.capture_complete'))
       expect(page).to have_text(t('doc_auth.instructions.switch_back'))
       expect_step_indicator_current_step(t('step_indicator.flows.idv.verify_id'))
+
+      # Confirm app disallows jumping back to DocumentCapture page
+      visit idv_hybrid_mobile_document_capture_url
+      expect(page).to have_current_path(idv_hybrid_mobile_capture_complete_url)
     end
 
     perform_in_browser(:desktop) do