Rename "signed_up" spec trait to "fully_registered"

spec/controllers/account_reset/cancel_controller_spec.rb

@@ -3,7 +3,7 @@
 describe AccountReset::CancelController do
   include AccountResetHelper
 
-  let(:user) { create(:user, :signed_up) }
+  let(:user) { create(:user, :fully_registered) }
 
   describe '#create' do
     it 'tracks IRS attempts event account_reset_cancel_request' do

spec/controllers/account_reset/delete_account_controller_spec.rb

@@ -10,7 +10,7 @@
 
   describe '#delete' do
     it 'logs a good token to the analytics' do
-      user = create(:user, :signed_up, :with_backup_code)
+      user = create(:user, :fully_registered, :with_backup_code)
       create(:phone_configuration, user: user, phone: Faker::PhoneNumber.cell_phone)
       create_list(:webauthn_configuration, 2, user: user)
       create_account_reset_request_for(user)

spec/controllers/account_reset/request_controller_spec.rb

@@ -53,7 +53,7 @@
     end
 
     it 'logs sms user in the analytics' do
-      user = create(:user, :signed_up)
+      user = create(:user, :fully_registered)
       stub_sign_in_before_2fa(user)
 
       stub_analytics

spec/controllers/accounts/personal_keys_controller_spec.rb

@@ -63,7 +63,7 @@
     end
 
     it 'prompts for password if PII is not present' do
-      user = create(:user, :signed_up, :with_piv_or_cac)
+      user = create(:user, :fully_registered, :with_piv_or_cac)
       create(:profile, :active, :verified, user: user)
       stub_sign_in(user)
 

spec/controllers/accounts_controller_spec.rb

@@ -14,7 +14,7 @@
     context 'when user has an active identity' do
       it 'renders the profile and does not redirect out of the app' do
         stub_analytics
-        user = create(:user, :signed_up)
+        user = create(:user, :fully_registered)
         user.identities << ServiceProviderIdentity.create(
           service_provider: 'http://localhost:3000',
           last_authenticated_at: Time.zone.now,
@@ -34,7 +34,7 @@
       it 'renders the profile and shows a deactivation banner' do
         user = create(
           :user,
-          :signed_up,
+          :fully_registered,
           profiles: [build(:profile, :active, :verified, pii: { first_name: 'Jane' })],
         )
         user.active_profile.deactivate(:password_reset)
@@ -62,7 +62,7 @@
       it 'renders the pending profile banner' do
         user = create(
           :user,
-          :signed_up,
+          :fully_registered,
           profiles: [build(:profile, deactivation_reason: :gpo_verification_pending)],
         )
 
@@ -79,7 +79,7 @@
         it 'renders a locked profile' do
           user = create(
             :user,
-            :signed_up,
+            :fully_registered,
             profiles: [build(:profile, :active, :verified, pii: { first_name: 'Jane' })],
           )
 

spec/controllers/api/internal/sessions_controller_spec.rb

@@ -19,7 +19,7 @@
     end
 
     context 'signed in' do
-      let(:user) { create(:user, :signed_up) }
+      let(:user) { create(:user, :fully_registered) }
 
       it 'responds with live and timeout properties' do
         expect(response).to eq(live: true, timeout: User.timeout_in.from_now.as_json)

spec/controllers/api/verify/document_capture_controller_spec.rb

@@ -19,7 +19,7 @@
   let!(:document_capture_session) { DocumentCaptureSession.create!(user: create(:user)) }
   let(:document_capture_session_uuid) { document_capture_session.uuid }
   let(:password) { 'iambatman' }
-  let(:user) { create(:user, :signed_up) }
+  let(:user) { create(:user, :fully_registered) }
   let(:flow_path) { 'standard' }
   let(:analytics_data) do
     { browser_attributes:

spec/controllers/concerns/idv_step_concern_spec.rb

@@ -1,7 +1,7 @@
 require 'rails_helper'
 
 describe 'IdvStepConcern' do
-  let(:user) { create(:user, :signed_up, email: 'old_email@example.com') }
+  let(:user) { create(:user, :fully_registered, email: 'old_email@example.com') }
   let(:idv_session) do
     Idv::Session.new(user_session: subject.user_session, current_user: user, service_provider: nil)
   end

spec/controllers/concerns/reauthentication_required_concern_spec.rb

@@ -1,7 +1,7 @@
 require 'rails_helper'
 
 describe ReauthenticationRequiredConcern, type: :controller do
-  let(:user) { create(:user, :signed_up, email: 'old_email@example.com') }
+  let(:user) { create(:user, :fully_registered, email: 'old_email@example.com') }
 
   describe '#confirm_recently_authenticated' do
     controller ApplicationController do

spec/controllers/idv/come_back_later_controller_spec.rb

@@ -1,7 +1,7 @@
 require 'rails_helper'
 
 describe Idv::ComeBackLaterController do
-  let(:user) { build_stubbed(:user, :signed_up) }
+  let(:user) { build_stubbed(:user, :fully_registered) }
   let(:pending_profile_requires_verification) { true }
 
   before do

spec/controllers/idv/doc_auth_controller_spec.rb

@@ -417,7 +417,7 @@ def mock_next_step(step)
     allow_any_instance_of(Idv::Flows::DocAuthFlow).to receive(:next_step).and_return(step)
   end
 
-  let(:user) { create(:user, :signed_up) }
+  let(:user) { create(:user, :fully_registered) }
   let(:document_capture_session_uuid) { DocumentCaptureSession.create!(user: user).uuid }
 
   def mock_document_capture_step

spec/controllers/idv/not_verified_controller_spec.rb

@@ -1,7 +1,7 @@
 require 'rails_helper'
 
 describe Idv::NotVerifiedController do
-  let(:user) { build_stubbed(:user, :signed_up) }
+  let(:user) { build_stubbed(:user, :fully_registered) }
 
   before do
     stub_sign_in(user)

spec/controllers/idv/personal_key_controller_spec.rb

@@ -28,7 +28,7 @@ def stub_idv_session
   end
 
   let(:password) { 'sekrit phrase' }
-  let(:user) { create(:user, :signed_up, password: password) }
+  let(:user) { create(:user, :fully_registered, password: password) }
   let(:applicant) { Idp::Constants::MOCK_IDV_APPLICANT_WITH_PHONE }
   let(:profile) { subject.idv_session.profile }
   let(:idv_session) do

spec/controllers/idv/review_controller_spec.rb

@@ -6,7 +6,7 @@
   let(:user) do
     create(
       :user,
-      :signed_up,
+      :fully_registered,
       password: ControllerHelper::VALID_PASSWORD,
       email: 'old_email@example.com',
     )

spec/controllers/idv/session_errors_controller_spec.rb

@@ -53,7 +53,7 @@
 
   context 'the user is not authenticated and in doc capture flow' do
     before do
-      user = create(:user, :signed_up)
+      user = create(:user, :fully_registered)
       controller.session[:doc_capture_user_id] = user.id
     end
     it 'renders the error' do

spec/controllers/mfa_confirmation_controller_spec.rb

@@ -99,7 +99,7 @@
   describe 'password attempts counter' do
     context 'max password attempts reached' do
       it 'signs the user out' do
-        user = create(:user, :signed_up)
+        user = create(:user, :fully_registered)
         sign_in user
         session[:password_attempts] = 0
         stub_analytics

spec/controllers/openid_connect/authorization_controller_spec.rb

@@ -28,7 +28,7 @@
     subject(:action) { get :index, params: params }
 
     context 'user is signed in' do
-      let(:user) { create(:user, :signed_up) }
+      let(:user) { create(:user, :fully_registered) }
       before do
         stub_sign_in user
       end

spec/controllers/password_capture_controller_spec.rb

@@ -2,7 +2,7 @@
 
 describe PasswordCaptureController do
   describe '#update' do
-    let(:user) { create(:user, :signed_up, password: 'a really long sekrit') }
+    let(:user) { create(:user, :fully_registered, password: 'a really long sekrit') }
 
     context 'form returns success' do
       let(:pii) { { first_name: 'Jane', ssn: '111-11-1111' } }

spec/controllers/saml_idp_controller_spec.rb

@@ -144,8 +144,8 @@
     let(:other_sp) { create(:service_provider, active: true, agency_id: agency.id) }
 
     let(:session_id) { 'abc123' }
-    let(:user) { create(:user, :signed_up) }
-    let(:other_user) { create(:user, :signed_up) }
+    let(:user) { create(:user, :fully_registered) }
+    let(:other_user) { create(:user, :fully_registered) }
 
     let!(:identity) do
       ServiceProviderIdentity.create(
@@ -622,7 +622,7 @@ def name_id_version(format_urn)
 
     context 'with IAL1' do
       it 'does not redirect the user to the IdV URL' do
-        user = create(:user, :signed_up)
+        user = create(:user, :fully_registered)
         generate_saml_response(user, saml_settings)
 
         expect(response).to_not be_redirect
@@ -775,7 +775,7 @@ def name_id_version(format_urn)
     end
 
     context 'authn_context scenarios' do
-      let(:user) { create(:user, :signed_up) }
+      let(:user) { create(:user, :fully_registered) }
 
       context 'authn_context is missing' do
         let(:auth_settings) { saml_settings(overrides: { authn_context: nil }) }
@@ -891,7 +891,7 @@ def name_id_version(format_urn)
     end
 
     context 'with ForceAuthn' do
-      let(:user) { create(:user, :signed_up) }
+      let(:user) { create(:user, :fully_registered) }
 
       it 'signs user out if a session is active and sp_session[:final_auth_request] is falsey' do
         sign_in(user)
@@ -921,7 +921,7 @@ def name_id_version(format_urn)
 
     context 'service provider is inactive' do
       it 'responds with an error page' do
-        user = create(:user, :signed_up)
+        user = create(:user, :fully_registered)
 
         generate_saml_response(
           user,
@@ -936,7 +936,7 @@ def name_id_version(format_urn)
 
     context 'service provider is invalid' do
       it 'responds with an error page' do
-        user = create(:user, :signed_up)
+        user = create(:user, :fully_registered)
 
         stub_analytics
         allow(@analytics).to receive(:track_event)
@@ -965,7 +965,7 @@ def name_id_version(format_urn)
 
     context 'both service provider and authn_context are invalid' do
       it 'responds with an error page' do
-        user = create(:user, :signed_up)
+        user = create(:user, :fully_registered)
 
         stub_analytics
         allow(@analytics).to receive(:track_event)
@@ -1033,7 +1033,7 @@ def name_id_version(format_urn)
       end
 
       it 'encrypts the response to the right key' do
-        user = create(:user, :signed_up)
+        user = create(:user, :fully_registered)
         generate_saml_response(user, second_cert_settings)
 
         expect(response).to_not be_redirect
@@ -1055,15 +1055,15 @@ def name_id_version(format_urn)
       end
 
       it 'deoes not blow up' do
-        user = create(:user, :signed_up)
+        user = create(:user, :fully_registered)
 
         expect { generate_saml_response(user, second_cert_settings) }.to_not raise_error
       end
     end
 
     context 'POST to auth correctly stores SP in session' do
       before do
-        @user = create(:user, :signed_up)
+        @user = create(:user, :fully_registered)
         @saml_request = saml_request(saml_settings)
         @post_request = saml_post_auth(@saml_request)
         @stored_request_url = @post_request.request.original_url +
@@ -1097,7 +1097,7 @@ def name_id_version(format_urn)
 
     context 'service provider is valid' do
       before do
-        @user = create(:user, :signed_up)
+        @user = create(:user, :fully_registered)
         @saml_request = saml_get_auth(saml_settings)
       end
 
@@ -1158,7 +1158,7 @@ def name_id_version(format_urn)
     end
 
     context 'service provider uses email NameID format and is allowed to use email' do
-      let(:user) { create(:user, :signed_up) }
+      let(:user) { create(:user, :fully_registered) }
 
       before do
         settings = saml_settings(
@@ -1204,7 +1204,7 @@ def name_id_version(format_urn)
     end
 
     context 'no matching cert from the SAML request' do
-      let(:user) { create(:user, :signed_up) }
+      let(:user) { create(:user, :fully_registered) }
 
       before do
         stub_analytics
@@ -1254,7 +1254,7 @@ def name_id_version(format_urn)
     end
 
     context 'no IAL explicitly requested' do
-      let(:user) { create(:user, :signed_up) }
+      let(:user) { create(:user, :fully_registered) }
 
       before do
         stub_analytics
@@ -1295,7 +1295,7 @@ def name_id_version(format_urn)
     end
 
     context 'nameid_format is missing' do
-      let(:user) { create(:user, :signed_up) }
+      let(:user) { create(:user, :fully_registered) }
 
       before do
         stub_analytics
@@ -1397,7 +1397,7 @@ def name_id_version(format_urn)
     end
 
     context 'service provider sends unsupported NameID format' do
-      let(:user) { create(:user, :signed_up) }
+      let(:user) { create(:user, :fully_registered) }
       let(:xmldoc) { SamlResponseDoc.new('controller', 'response_assertion', response) }
       let(:subject) { xmldoc.subject_nodeset[0] }
       let(:name_id) { subject.at('//ds:NameID', ds: Saml::XML::Namespaces::ASSERTION) }
@@ -1549,7 +1549,7 @@ def name_id_version(format_urn)
 
     context 'after signing in' do
       it 'does not call IdentityLinker' do
-        user = create(:user, :signed_up)
+        user = create(:user, :fully_registered)
         linker = instance_double(IdentityLinker)
 
         expect(IdentityLinker).to_not receive(:new)
@@ -1563,7 +1563,7 @@ def name_id_version(format_urn)
       let(:issuer) { xmldoc.issuer_nodeset[0] }
       let(:status) { xmldoc.status[0] }
       let(:status_code) { xmldoc.status_code[0] }
-      let(:user) { create(:user, :signed_up) }
+      let(:user) { create(:user, :fully_registered) }
 
       before do
         generate_saml_response(user, saml_settings)
@@ -2005,7 +2005,7 @@ def stub_requested_attributes
 
     context 'user is not redirected to IdV' do
       it 'tracks the authentication without IdV redirection event' do
-        user = create(:user, :signed_up)
+        user = create(:user, :fully_registered)
 
         stub_analytics
         allow(controller).to receive(:identity_needs_verification?).and_return(false)
@@ -2040,7 +2040,7 @@ def stub_requested_attributes
 
     context 'user has not finished verifying profile' do
       it 'tracks the authentication with finish_profile==true' do
-        user = create(:user, :signed_up)
+        user = create(:user, :fully_registered)
 
         stub_analytics
         allow(controller).to receive(:identity_needs_verification?).and_return(false)

spec/controllers/saml_signed_message_spec.rb

@@ -14,7 +14,7 @@
 
   describe 'GET /api/saml/auth' do
     context "SP's can have signed_response_message_requested set" do
-      let(:user) { create(:user, :signed_up) }
+      let(:user) { create(:user, :fully_registered) }
       let(:saml_response_encoded) do
         Nokogiri::HTML(response.body).css('#SAMLResponse').first.attributes['value'].to_s
       end