This repository was archived by the owner on Feb 11, 2025. It is now read-only.
Merged
Conversation
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
mitchellhenke
force-pushed
the
mitchellhenke/fix-fallback
branch
from
1a24c5d to
ebc27f0
Compare
added 2 commits
April 25, 2023 12:42
mitchellhenke
force-pushed
the
mitchellhenke/fix-fallback
branch
from
c7b61d8 to
31d2adf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing 18F/identity-idp#8253, I found an issue where it's possible to receive an inconsistent read from a fallback key because there's no stage where we write to both keys. To ensure the migration is compatible with zero-downtime, I've added a couple more configuration keys. I've also updated the README to document the migration process as well as our differences from the upstream repository.