Skip to content

Remove code for unused no-SP registration heading #8107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduth merged 1 commit into from
Mar 31, 2023
Merged

Remove code for unused no-SP registration heading #8107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions app/decorators/service_provider_session_decorator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,6 @@ def new_session_heading
I18n.t('headings.sign_in_with_sp', sp: sp_name)
end

def registration_heading
'sign_up/registrations/sp_registration_heading'
end

def verification_method_choice
I18n.t('idv.messages.select_verification_with_sp', sp_name: sp_name)
end
Expand Down
4 changes: 0 additions & 4 deletions app/decorators/session_decorator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,6 @@ def initialize(view_context: nil)
@view_context = view_context
end

def registration_heading
'sign_up/registrations/registration_heading'
end

def new_session_heading
I18n.t('headings.sign_in_without_sp')
end
Expand Down
6 changes: 1 addition & 5 deletions app/views/devise/sessions/new.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,7 @@
<%= render 'shared/maintenance_window_alert' %>

<% if decorated_session.sp_name %>
<div class='text-center'>
<%= image_tag(asset_url('user-access.svg'), width: '280', height: '91', alt: '') %>

<%= render decorated_session.registration_heading %>
</div>
<%= render 'sign_up/registrations/sp_registration_heading' %>
<% else %>
<%= render PageHeadingComponent.new.with_content(decorated_session.new_session_heading) %>
<% end %>
Expand Down
3 changes: 0 additions & 3 deletions app/views/sign_up/registrations/_registration_heading.html.erb
View file
Open in desktop

This file was deleted.

14 changes: 7 additions & 7 deletions app/views/sign_up/registrations/_sp_registration_heading.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<h1 class='margin-bottom-4 text-primary text-normal'>
<strong>
<%= decorated_session.sp_name %>
</strong>

<%= t('headings.create_account_with_sp.sp_text', app_name: APP_NAME) %>
</h1>
<div class="text-center">
<%= image_tag(asset_url('user-access.svg'), width: '280', height: '91', alt: '') %>
<h1 class="margin-bottom-4 text-primary text-normal">
<strong><%= decorated_session.sp_name %></strong>
<%= t('headings.create_account_with_sp.sp_text', app_name: APP_NAME) %>
</h1>
</div>
6 changes: 1 addition & 5 deletions app/views/users/authorization_confirmation/new.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,7 @@
<% title t('titles.sign_up.confirmation') %>

<% if decorated_session.sp_name %>
<div class='text-center'>
<%= image_tag(asset_url('user-access.svg'), width: '280', height: '91', alt: '') %>

<%= render decorated_session.registration_heading %>
</div>
<%= render 'sign_up/registrations/sp_registration_heading' %>
<% else %>
<%= render PageHeadingComponent.new.with_content(decorated_session.new_session_heading) %>
<% end %>
Expand Down
1 change: 0 additions & 1 deletion config/locales/headings/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ en:
cta: First time using %{app_name}?
sp_text: is using %{app_name} to allow you to sign in to your account safely and
securely.
create_account_without_sp: Create a %{app_name} account
edit_info:
password: Change your password
phone: Manage your phone settings
Expand Down
1 change: 0 additions & 1 deletion config/locales/headings/es.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ es:
cta: '¿Es la primera vez que utiliza %{app_name}?'
sp_text: está utilizando %{app_name} para permitirle iniciar sesión en su cuenta
de forma segura.
create_account_without_sp: Establezca una cuenta de %{app_name}
edit_info:
password: Cambie su contraseña
phone: Administrar la configuración de su teléfono
Expand Down
1 change: 0 additions & 1 deletion config/locales/headings/fr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ fr:
cta: Première fois que vous utilisez %{app_name}?
sp_text: utilise %{app_name} pour vous permettre de vous connecter à votre
compte de façon sûre et sécurisée.
create_account_without_sp: Créer un compte %{app_name}
edit_info:
password: Changez votre mot de passe
phone: Administrer les paramètres de votre téléphone
Expand Down
6 changes: 0 additions & 6 deletions spec/decorators/session_decorator_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,6 @@
end
end

describe '#registration_heading' do
it 'returns the correct partial' do
expect(subject.registration_heading).to eq 'sign_up/registrations/registration_heading'
end
end

describe '#verification_method_choice' do
it 'returns the correct string' do
expect(subject.verification_method_choice).to eq(
Expand Down