Refactor of USPS proofing job spec to eliminate flakey tests

spec/jobs/get_usps_proofing_results_job_spec.rb

@@ -10,35 +10,35 @@
       )
 
       job.perform(Time.zone.now)
-    end
 
-    response = JSON.parse(response_json)
-    expect(job_analytics).to have_logged_event(
-      'GetUspsProofingResultsJob: Enrollment status updated',
-      assurance_level: response['assuranceLevel'],
-      enrollment_code: pending_enrollment.enrollment_code,
-      enrollment_id: pending_enrollment.id,
-      failure_reason: response['failureReason'],
-      fraud_suspected: response['fraudSuspected'],
-      issuer: pending_enrollment.issuer,
-      minutes_since_last_status_check: 15.0,
-      minutes_since_last_status_update: 2.days.in_minutes,
-      minutes_to_completion: 3.days.in_minutes,
-      minutes_since_established: 3.days.in_minutes,
-      passed: passed,
-      primary_id_type: response['primaryIdType'],
-      proofing_city: response['proofingCity'],
-      proofing_post_office: response['proofingPostOffice'],
-      proofing_state: response['proofingState'],
-      reason: anything,
-      response_message: response['responseMessage'],
-      response_present: true,
-      scan_count: response['scanCount'],
-      secondary_id_type: response['secondaryIdType'],
-      status: response['status'],
-      transaction_end_date_time: anything,
-      transaction_start_date_time: anything,
-    )
+      response = JSON.parse(response_json)
+      expect(job_analytics).to have_logged_event(
+        'GetUspsProofingResultsJob: Enrollment status updated',
+        assurance_level: response['assuranceLevel'],
+        enrollment_code: pending_enrollment.enrollment_code,
+        enrollment_id: pending_enrollment.id,
+        failure_reason: response['failureReason'],
+        fraud_suspected: response['fraudSuspected'],
+        issuer: pending_enrollment.issuer,
+        minutes_since_last_status_check: 15.0,
+        minutes_since_last_status_update: 2.days.in_minutes,
+        minutes_to_completion: 3.days.in_minutes,
+        minutes_since_established: 3.days.in_minutes,
+        passed: passed,
+        primary_id_type: response['primaryIdType'],
+        proofing_city: response['proofingCity'],
+        proofing_post_office: response['proofingPostOffice'],
+        proofing_state: response['proofingState'],
+        reason: anything,
+        response_message: response['responseMessage'],
+        response_present: true,
+        scan_count: response['scanCount'],
+        secondary_id_type: response['secondaryIdType'],
+        status: response['status'],
+        transaction_end_date_time: anything,
+        transaction_start_date_time: anything,
+      )
+    end
   end
 
   context 'email_analytics_attributes' do
@@ -72,11 +72,9 @@
       pending_enrollment.reload
       expect(pending_enrollment.status_updated_at).to eq(Time.zone.now)
       expect(pending_enrollment.status_check_attempted_at).to eq(Time.zone.now)
+      expect(pending_enrollment.status).to eq(status)
+      expect(pending_enrollment.profile.active).to eq(passed)
     end
-
-    expect(pending_enrollment.status).to eq(status)
-
-    expect(pending_enrollment.profile.active).to eq(passed)
   end
 end
 
@@ -94,7 +92,6 @@
     expect(job_analytics).to have_logged_event(
       'GetUspsProofingResultsJob: Exception raised',
       hash_including(
-        minutes_since_established: range_approximating(3.days.in_minutes, vary_right: 5),
         enrollment_code: pending_enrollment.enrollment_code,
         enrollment_id: pending_enrollment.id,
         exception_class: exception_class,
@@ -129,7 +126,7 @@
     expect(job_analytics).to have_logged_event(
       'GetUspsProofingResultsJob: Exception raised',
       hash_including(
-        minutes_since_established: range_approximating(3.days.in_minutes, vary_right: 5),
+        reason: 'Request exception',
         response_present: false,
         exception_class: error_type.to_s,
       ),
@@ -311,8 +308,9 @@
           expect(job_analytics).to have_logged_event(
             'GetUspsProofingResultsJob: Exception raised',
             hash_including(
-              minutes_since_established: range_approximating(3.days.in_minutes, vary_right: 5),
               exception_message: error_message,
+              exception_class: 'StandardError',
+              reason: 'Request exception',
             ),
           )
         end
@@ -518,8 +516,8 @@
           expect(job_analytics).to have_logged_event(
             'GetUspsProofingResultsJob: Enrollment status updated',
             hash_including(
-              minutes_since_established: range_approximating(3.days.in_minutes, vary_right: 5),
               reason: 'Successful status update',
+              passed: true,
             ),
           )
           expect(job_analytics).to have_logged_event(
@@ -530,14 +528,6 @@
             timestamp: anything,
             wait_until: nil,
           )
-
-          expect(job_analytics).to have_logged_event(
-            'GetUspsProofingResultsJob: Enrollment status updated',
-            hash_including(
-              transaction_end_date_time: transaction_end_date_time,
-              transaction_start_date_time: transaction_start_date_time,
-            ),
-          )
         end
       end
 
@@ -561,7 +551,8 @@
           expect(job_analytics).to have_logged_event(
             'GetUspsProofingResultsJob: Enrollment status updated',
             hash_including(
-              minutes_since_established: range_approximating(3.days.in_minutes, vary_right: 5),
+              passed: false,
+              reason: 'Failed status',
             ),
           )
           expect(job_analytics).to have_logged_event(
@@ -572,14 +563,6 @@
             timestamp: anything,
             wait_until: nil,
           )
-
-          expect(job_analytics).to have_logged_event(
-            'GetUspsProofingResultsJob: Enrollment status updated',
-            hash_including(
-              transaction_end_date_time: transaction_end_date_time,
-              transaction_start_date_time: transaction_start_date_time,
-            ),
-          )
         end
       end
 
@@ -603,7 +586,9 @@
           expect(job_analytics).to have_logged_event(
             'GetUspsProofingResultsJob: Enrollment status updated',
             hash_including(
-              minutes_since_established: range_approximating(3.days.in_minutes, vary_right: 5),
+              fraud_suspected: true,
+              passed: false,
+              reason: 'Failed status',
             ),
           )
           expect(job_analytics).to have_logged_event(
@@ -614,14 +599,6 @@
             timestamp: anything,
             wait_until: nil,
           )
-
-          expect(job_analytics).to have_logged_event(
-            'GetUspsProofingResultsJob: Enrollment status updated',
-            hash_including(
-              transaction_end_date_time: transaction_end_date_time,
-              transaction_start_date_time: transaction_start_date_time,
-            ),
-          )
         end
       end
 
@@ -645,10 +622,8 @@
           expect(job_analytics).to have_logged_event(
             'GetUspsProofingResultsJob: Enrollment status updated',
             hash_including(
-              minutes_since_established: range_approximating(3.days.in_minutes, vary_right: 5),
+              passed: false,
               reason: 'Unsupported ID type',
-              transaction_end_date_time: transaction_end_date_time,
-              transaction_start_date_time: transaction_start_date_time,
             ),
           )
 
@@ -683,7 +658,6 @@
           expect(job_analytics).to have_logged_event(
             'GetUspsProofingResultsJob: Enrollment status updated',
             hash_including(
-              minutes_since_established: range_approximating(3.days.in_minutes, vary_right: 5),
               reason: 'Enrollment has expired',
               transaction_end_date_time: nil,
               transaction_start_date_time: nil,
@@ -714,7 +688,7 @@
           expect(job_analytics).to have_logged_event(
             'GetUspsProofingResultsJob: Enrollment status updated',
             hash_including(
-              minutes_since_established: range_approximating(3.days.in_minutes, vary_right: 5),
+              passed: false,
               reason: 'Enrollment has expired',
             ),
           )
@@ -744,8 +718,8 @@
             expect(job_analytics).to have_logged_event(
               'GetUspsProofingResultsJob: Unexpected response received',
               hash_including(
-                minutes_since_established: range_approximating(3.days.in_minutes, vary_right: 5),
                 reason: 'Invalid enrollment code',
+                response_message: /Enrollment code [0-9]{16} does not exist/,
               ),
             )
           end
@@ -768,8 +742,8 @@
             expect(job_analytics).to have_logged_event(
               'GetUspsProofingResultsJob: Unexpected response received',
               hash_including(
-                minutes_since_established: range_approximating(3.days.in_minutes, vary_right: 5),
                 reason: 'Invalid applicant unique id',
+                response_message: /Applicant [0-9a-z]{18} does not exist/,
               ),
             )
           end
@@ -805,7 +779,6 @@
           expect(job_analytics).to have_logged_event(
             'GetUspsProofingResultsJob: Exception raised',
             hash_including(
-              minutes_since_established: range_approximating(3.days.in_minutes, vary_right: 5),
               status: 'Not supported',
             ),
           )
@@ -920,11 +893,6 @@
           expect(job_analytics).not_to have_logged_event(
             'GetUspsProofingResultsJob: Enrollment status updated',
           )
-
-          expect(job_analytics).to have_logged_event(
-            'GetUspsProofingResultsJob: Enrollment incomplete',
-            hash_including(minutes_since_established: 3.days.in_minutes),
-          )
         end
       end