Conversation
changelog: Internal, Code Quality, Reconcile routes for adding phone
RackAttack throttles for any non-GET request, not specifically on the PATCH method: https://github.com/18F/identity-idp/blob/e10b263/config/initializers/rack_attack.rb#L202
Contributor
Author
|
#7944 was deployed in RC 260, so this is no longer blocked. |
aduth
commented
Mar 13, 2023
| it 'does not throttle the request' do | ||
| (phone_setups_per_ip_limit - 1).times do | ||
| patch '/phone_setup', headers: { REMOTE_ADDR: '1.2.3.4' } | ||
| post '/phone_setup', headers: { REMOTE_ADDR: '1.2.3.4' } |
Contributor
Author
There was a problem hiding this comment.
As mentioned in the extended commit message, this is fortunately not cause for concern, since throttling applies to any non-GET request:
mitchellhenke
pushed a commit
that referenced
this pull request
Mar 14, 2023
* Remove unused phone PATCH route changelog: Internal, Code Quality, Reconcile routes for adding phone * Update spec method RackAttack throttles for any non-GET request, not specifically on the PATCH method: https://github.com/18F/identity-idp/blob/e10b263/config/initializers/rack_attack.rb#L202
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE until after #7944 has been deployed to production.
🛠 Summary of changes
Follow-up to #7944 (and #7826) to remove the phone creation
PATCHroute, which has to be removed separately to avoid issues during deployment.