Skip to content

Remove unused phone PATCH route #7947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduth merged 2 commits into from
Mar 14, 2023
Merged

Remove unused phone PATCH route #7947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
552115f
Remove unused phone PATCH route
aduth Mar 8, 2023
07ad35e
Update spec method
aduth Mar 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion config/routes.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,6 @@
get '/second_mfa_setup' => 'users/mfa_selection#index'
patch '/second_mfa_setup' => 'users/mfa_selection#update'
get '/phone_setup' => 'users/phone_setup#index'
patch '/phone_setup' => 'users/phone_setup#create' # TODO: Remove after next deploy
post '/phone_setup' => 'users/phone_setup#create'
get '/users/two_factor_authentication' => 'users/two_factor_authentication#show',
as: :user_two_factor_authentication # route name is used by two_factor_authentication gem
Expand Down
4 changes: 2 additions & 2 deletions spec/requests/rack_attack_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,7 @@
context 'when the number of requests is under the limit' do
it 'does not throttle the request' do
(phone_setups_per_ip_limit - 1).times do
patch '/phone_setup', headers: { REMOTE_ADDR: '1.2.3.4' }
post '/phone_setup', headers: { REMOTE_ADDR: '1.2.3.4' }
Copy link
Contributor Author

@aduth aduth Mar 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in the extended commit message, this is fortunately not cause for concern, since throttling applies to any non-GET request:

identity-idp/config/initializers/rack_attack.rb

Line 202 in e10b263

req.remote_ip if req.path.match?(%r{/add/phone|/phone_setup}) && !req.get?

end

expect(response.status).to eq(302)
Expand All @@ -404,7 +404,7 @@
context 'when the number of requests is over the limit' do
it 'throttles the request' do
(phone_setups_per_ip_limit + 1).times do
patch '/phone_setup', headers: { REMOTE_ADDR: '1.2.3.4' }
post '/phone_setup', headers: { REMOTE_ADDR: '1.2.3.4' }
end

expect(response.status).to eq(429)
Expand Down