Use POST route consistently for phone creation#7944
Merged
Conversation
Contributor
Author
|
I should flag that this creates some inconsistency with other MFA setup paths which still use |
mitchellhenke
approved these changes
Mar 7, 2023
zachmargolis
approved these changes
Mar 7, 2023
changelog: Internal, Code Quality, Reconcile routes for adding phone
6642cc6 to
3749a39
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
This pull request aims to address some incomplete refactoring started in #7826 and work toward reconciling (and hopefully consolidating) phone creation routes.
In #7826, the new spam protection screen reused POST routes for phone creation with the expectation that we would remove PATCH as a supported verb, reflected in
routes.rbonmain:identity-idp/config/routes.rb
Lines 254 to 255 in 3a3b3a9
However, we never updated the existing reference to the PATCH route in
app/views/users/phone_setup/index.html.erb, which is updated here.This also removes a
data-attribute which, as best I can tell, is not used. (It was added in #3253, though was never used from what I can see)📜 Testing Plan