Make phone number non-editable LG-1722#3253
Merged
Conversation
jmhooper
reviewed
Sep 4, 2019
| in_array(PhoneNumberCapabilities::INTERNATIONAL_CODES.keys) | ||
| end | ||
|
|
||
| it 'validates that the number matches the requested international code' do |
Contributor
There was a problem hiding this comment.
Some of these tests still look useful. What is the reason for removing them?
Contributor
Author
There was a problem hiding this comment.
Removed by mistake. Re-added.
stevegsa
reviewed
Sep 4, 2019
| bypass_sign_in current_user | ||
| else | ||
| render_edit | ||
| render :edit |
stevegsa
reviewed
Sep 4, 2019
| return true if phone_configuration&.delivery_preference != otp_delivery_preference | ||
| return true if otp_make_default_number && !default_phone_configuration? | ||
| false | ||
| user.phone_configurations.map(&:phone).include?(phone) |
…eration which form they are submitting data to
achapm
approved these changes
Sep 9, 2019
Contributor
achapm
left a comment
achapm
left a comment
There was a problem hiding this comment.
👍 Great work Clara. Looks like you covered everything I remember from our last review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.