Skip to content

Skip redundant delete and save of service provider authorization requests #7910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchellhenke merged 2 commits into from
Mar 1, 2023
Merged

Skip redundant delete and save of service provider authorization requests #7910

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
696db41
Skip redundant delete and save of service provider authorization requ…
Mar 1, 2023
48db8d0
Update app/services/service_provider_request_handler.rb
Mar 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion app/services/service_provider_request_handler.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ def initialize(url:, session:, protocol_request:, protocol:)
end

def call
return if sp_url_stored_in_session == url
Copy link
Contributor Author

@mitchellhenke mitchellhenke Mar 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has the same vibes as the change here that was fixed here. This should still allow for the same service provider with differing nonces (or other attributes).


pull_request_id_from_current_sp_session_id

delete_sp_request_if_session_has_matching_request_id
Expand Down Expand Up @@ -34,8 +36,17 @@ def current_sp
end

def sp_stored_in_session
service_provider_request_proxy&.issuer
end

def sp_url_stored_in_session
service_provider_request_proxy&.url
end

def service_provider_request_proxy
return if sp_request_id.blank?
ServiceProviderRequestProxy.from_uuid(sp_request_id).issuer
return @service_provider_request_proxy if defined?(@service_provider_request_proxy)
@service_provider_request_proxy = ServiceProviderRequestProxy.from_uuid(sp_request_id)
end

def pull_request_id_from_current_sp_session_id
Expand Down