Skip to content

LG-8762: add cancel link to completion screen, redirect to SP without consent happening if you don't agree. #7896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdiarra3 merged 5 commits into from
Mar 2, 2023
Merged

LG-8762: add cancel link to completion screen, redirect to SP without consent happening if you don't agree. #7896

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
98d8373
changelog: User-Facing Improvements, Authentication, add cancel link …
mdiarra3 Feb 27, 2023
9ef5a9f
add cancel link
mdiarra3 Feb 27, 2023
b9a0bd4
add cancel link
mdiarra3 Mar 1, 2023
c2dcc02
shows html
mdiarra3 Mar 1, 2023
691bba2
update styling for form
mdiarra3 Mar 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions app/views/sign_up/completions/show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,11 @@
<%= t('mfa.second_method_warning.text') %>
<% end %>
<% end %>
<p>
<%= simple_form_for(:idv_form, url: sign_up_completed_path) do |f| %>
<%= f.submit t('sign_up.agree_and_continue') %>
<% end %>
</p>

<%= simple_form_for(:idv_form, url: sign_up_completed_path, html: { class: 'margin-y-5' }) do |f| %>
<%= f.submit t('sign_up.agree_and_continue') %>
<% end %>

<%= render PageFooterComponent.new do %>
<%= link_to t('links.cancel'), return_to_sp_cancel_path %>
<% end %>
8 changes: 8 additions & 0 deletions spec/views/sign_up/completions/show.html.erb_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,14 @@
)
end

it 'shows cancel link on completion screen' do
render
expect(rendered).to have_link(
t('links.cancel'),
href: return_to_sp_cancel_path,
)
end

context 'the all_emails scope is requested' do
let(:requested_attributes) { [:email, :all_emails] }

Expand Down