Pre-calculate CORS domains in cache rather than calculating every time#7785
Merged
mitchellhenke merged 4 commits intomainfrom Feb 7, 2023
Merged
Pre-calculate CORS domains in cache rather than calculating every time#7785mitchellhenke merged 4 commits intomainfrom
mitchellhenke merged 4 commits intomainfrom
Conversation
changelog: Internal, Cross-Origin Resource Sharing, Pre-calculate CORS domains in cache rather than calculating every time
mitchellhenke
force-pushed
the
mitchellhenke/cors-faster
branch
from
d42dbc2 to
68322d0
Compare
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
aduth
reviewed
Feb 7, 2023
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
This PR lifts the calculation of protocols/domains to store them in the cache rather than storing the redirect URIs themselves and re-calculating on each CORS request.