Skip to content

Pre-calculate CORS domains in cache rather than calculating every time #7785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchellhenke merged 4 commits into from
Feb 7, 2023
Merged

Pre-calculate CORS domains in cache rather than calculating every time #7785

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
68322d0
Pre-calculate CORS domains in cache rather than calculating every time
Feb 7, 2023
6e37128
Update config/application.rb
Feb 7, 2023
21fb1b7
underscore unused variable
Feb 7, 2023
8523bed
Update config/application.rb
Feb 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions config/application.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,18 +117,18 @@ class Application < Rails::Application
next if source == IdentityConfig.store.domain_name

redirect_uris = Rails.cache.fetch(
'all_service_provider_redirect_uris',
'all_service_provider_redirect_uris_cors',
expires_in: IdentityConfig.store.all_redirect_uris_cache_duration_minutes.minutes,
) do
ServiceProvider.pluck(:redirect_uris).flatten.compact
ServiceProvider.pluck(:redirect_uris).flatten.compact.map do |uri|
split_uri = uri.split('//')
protocol = split_uri[0]
domain = split_uri[1].split('/')[0] if split_uri.size > 1
Comment thread
mitchellhenke marked this conversation as resolved.
Outdated
"#{protocol}//#{domain}"
end.uniq
end

redirect_uris.find do |uri|
split_uri = uri.split('//')
protocol = split_uri[0]
domain = split_uri[1].split('/')[0] if split_uri.size > 1
source == "#{protocol}//#{domain}"
end.present?
redirect_uris.any? { |uri| uri == source }
end
resource '/.well-known/openid-configuration', headers: :any, methods: [:get]
resource '/api/openid_connect/certs', headers: :any, methods: [:get]
Expand Down