Include protocol when checking internal domain for cross-origin resource sharing#7786
Merged
mitchellhenke merged 1 commit intomainfrom Feb 7, 2023
Merged
Include protocol when checking internal domain for cross-origin resource sharing#7786mitchellhenke merged 1 commit intomainfrom
mitchellhenke merged 1 commit intomainfrom
Conversation
changelog: Internal, Cross-Origin Resource Sharing, Include protocol when checking internal domain for CORS
aduth
reviewed
Feb 7, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
I noticed when working on #7785, that internal requests were not being skipped as intended, and it seems to be due to the request source including protocol AND domain, and us only comparing it against the domain. MDN has a fuller explanation, but the format and a few examples are:
On secure.login.gov,
IdentityConfig.store.domain_namereturnssecure.login.gov, and I pulled the request headers:which will never match 🙂
This PR adds
https://so that we skip the remaining checks as intended.