Skip to content

LG-8509: update selected location alert to include address #7727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svalexander merged 9 commits into from
Feb 1, 2023
Merged

LG-8509: update selected location alert to include address #7727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1afacfd
use streetAddress instead of name
svalexander Jan 30, 2023
56a5235
update test so selected_location is address
svalexander Jan 30, 2023
8354629
string update
svalexander Jan 30, 2023
8646dbc
changelog: User-Facing Improvements, Prepare page aler, update alert …
svalexander Jan 30, 2023
95dc952
update to include formattedcitystatezip
svalexander Jan 30, 2023
e358478
lint fix
svalexander Jan 31, 2023
af023af
analytics spec in progress
svalexander Jan 31, 2023
6faed83
location step uses name
svalexander Jan 31, 2023
a068e59
refactor
svalexander Feb 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ...cript/packages/document-capture/components/in-person-location-post-office-search-step.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,10 @@ function InPersonLocationPostOfficeSearchStep({ onChange, toPreviousStep, regist
const handleLocationSelect = useCallback(
async (e: any, id: number) => {
const selectedLocation = locationResults![id]!;
const { name: selectedLocationName } = selectedLocation;
setSubmitEventMetadata({ selected_location: selectedLocationName });
onChange({ selectedLocationName });
const { streetAddress, formattedCityStateZip } = selectedLocation;
const selectedLocationAddress = `${streetAddress}, ${formattedCityStateZip}`;
setSubmitEventMetadata({ selected_location: selectedLocationAddress });
onChange({ selectedLocationAddress });
if (autoSubmit) {
return;
}
Expand Down
13 changes: 11 additions & 2 deletions app/javascript/packages/document-capture/components/in-person-prepare-step.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ function InPersonPrepareStep({ toPreviousStep, value }) {
const { flowPath } = useContext(UploadContext);
const { trackEvent } = useContext(AnalyticsContext);
const { securityAndPrivacyHowItWorksURL } = useContext(MarketingSiteContext);
const { selectedLocationName } = value;
/* Remove selectedLocationName when request_pilot_facilities removed */
const { selectedLocationName, selectedLocationAddress } = value;

const onContinue: MouseEventHandler = async (event) => {
event.preventDefault();
Expand All @@ -35,13 +36,21 @@ function InPersonPrepareStep({ toPreviousStep, value }) {

return (
<>
{/* Remove selectedLocationName version of alert when request_pilot_facilities removed */}
{selectedLocationName && (
<Alert type="success" className="margin-bottom-4">
{t('in_person_proofing.body.prepare.alert_selected_post_office', {
{t('in_person_proofing.body.prepare.alert_selected_po_name', {
name: selectedLocationName,
})}
</Alert>
)}
{selectedLocationAddress && (
<Alert type="success" className="margin-bottom-4">
{t('in_person_proofing.body.prepare.alert_selected_post_office', {
full_address: selectedLocationAddress,
})}
</Alert>
)}
<PageHeading>{t('in_person_proofing.headings.prepare')}</PageHeading>

<p>{t('in_person_proofing.body.prepare.verify_step_about')}</p>
Expand Down
3 changes: 2 additions & 1 deletion config/locales/in_person_proofing/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,8 @@ en:
retail_hours_sun: 'Sun:'
retail_hours_weekday: 'Monday to Friday:'
prepare:
alert_selected_post_office: You’ve selected the %{name} Post Office.
alert_selected_po_name: You’ve selected the %{name} Post Office.
alert_selected_post_office: You’ve selected the Post Office at %{full_address}.
privacy_disclaimer: '%{app_name} is a secure, government website. We and the
U.S. Postal Service use your data to verify your identity.'
privacy_disclaimer_link: Learn more about privacy and security.
Expand Down
3 changes: 2 additions & 1 deletion config/locales/in_person_proofing/es.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,8 @@ es:
retail_hours_sun: 'Dom:'
retail_hours_weekday: 'De Lunes a Viernes:'
prepare:
alert_selected_post_office: Ha seleccionado la oficina de correos %{name}.
alert_selected_po_name: Ha seleccionado la oficina de correos %{name}.
alert_selected_post_office: Ha seleccionado la oficina de correos a %{full_address}.
privacy_disclaimer: '%{app_name} es un sitio web seguro del gobierno. Nosotros y
el Servicio Postal de los Estados Unidos utilizamos sus datos para
verificar su identidad.'
Expand Down
3 changes: 2 additions & 1 deletion config/locales/in_person_proofing/fr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,8 @@ fr:
retail_hours_sun: 'Dim:'
retail_hours_weekday: 'Lundi à Vendredi:'
prepare:
alert_selected_post_office: Vous avez sélectionné le bureau de poste de %{name}.
alert_selected_po_name: Vous avez sélectionné le bureau de poste de %{name}.
alert_selected_post_office: Vous avez sélectionné le bureau de poste à %{full_address}.
privacy_disclaimer: '%{app_name} est un site gouvernemental sécurisé. Nous et le
service postal américain utilisons vos données pour vérifier votre
identité.'
Expand Down