Move Faker gem from all environments to test#11757
Merged
mitchellhenke merged 1 commit intomainfrom Jan 16, 2025
Merged
Conversation
changelog: Internal, Maintenance, Move Faker gem from all environments to test
aduth
approved these changes
Jan 16, 2025
zachmargolis
added a commit
that referenced
this pull request
Jan 23, 2025
- Mailer previews occasionally load in production environments (sandbox) but in #11757, we moved the Faker gem to the test group (which breaks these previews in sandbox) - Removing the usage of Faker in the previews helps keep the previews working, and keeps the production dependencies smaller changelog: Internal, Source code, Remove gem dependency from mailer previews
zachmargolis
added a commit
that referenced
this pull request
Jan 23, 2025
- Mailer previews occasionally load in production environments (sandbox) but in #11757, we moved the Faker gem to the test group (which breaks these previews in sandbox) - Removing the usage of Faker in the previews helps keep the previews working, and keeps the production dependencies smaller changelog: Internal, Source code, Remove gem dependency from mailer previews
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
We moved
fakeroutside of the test group in #7698, and removed the non-test usage in #9154. This PR moves it back to the test group so we aren't unnecessarily installing it in non-test environments.