Use i18n pluralization to avoid ignored string#7667
Merged
Conversation
[skip changelog]
mdiarra3
approved these changes
Jan 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates
ReviewIssuesStepuse of localization to use pluralization feature.Follow-up to #7638 where upgraded
i18n-tasksdetected the direct reference to pluralized string keys as being unused.ReviewIssuesSteppredates the introduction of pluralization to the JavaScript implementation in #5950, hence why it was implemented the way it was.Related Slack discussion: https://gsa-tts.slack.com/archives/C04GA9WQ85B/p1674170306847209
📜 Testing Plan
yarn mocha spec/javascripts/packages/document-capture/components/review-issues-step-spec.jsx