Skip to content

LG-8402: Add a cancel link to the in-person proofing barcode page #7618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sheldon-b merged 5 commits into from
Jan 12, 2023
Merged

LG-8402: Add a cancel link to the in-person proofing barcode page #7618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9e9185a
Add a "Cancel your barcode" link to barcode page
Jan 10, 2023
1aa6adb
changelog: User-facing improvements, In-person proofing, Add a cancel…
Jan 11, 2023
f22749c
Remove todo comment
Jan 11, 2023
c20d02f
Remove style override
Jan 11, 2023
e8654f2
Lint localized content
Jan 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/views/idv/in_person/ready_to_verify/show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,3 +111,7 @@
</address>
</section>
<% end %>

<%= render PageFooterComponent.new do %>
<%= link_to t('in_person_proofing.body.barcode.cancel_link_text'), idv_cancel_path(step: 'verify') %>
<% end %>
Comment on lines +115 to +117
Copy link
Copy Markdown
Contributor

@allthesignals allthesignals Jan 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed that there's a shared partial for this (app/views/idv/doc_auth/_cancel.html.erb) and wonder if it could be re-used instead, or re-using this (app/views/shared/_cancel.html.erb) instead...

Copy link
Copy Markdown
Contributor Author

@sheldon-b sheldon-b Jan 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the reason I didn't use those is that they use a different text string for the link text ("Cancel" instead of "Cancel your barcode"). I considered adding a link text parameter to one of those but it didn't seem worth it since we're only doing this in one place and it doesn't seem likely that we'll want to do it elsewhere with different text again

1 change: 1 addition & 0 deletions config/locales/in_person_proofing/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ en:
need to bring proof of your current address to the Post Office.
learn_more: Learn more
barcode:
cancel_link_text: Cancel your barcode
close_window: You may now close this window.
deadline: Visit the Post Office by %{deadline}.
deadline_restart: If you go after the deadline, your information will not be
Expand Down
1 change: 1 addition & 0 deletions config/locales/in_person_proofing/es.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ es:
dirección actual.
learn_more: Aprende más
barcode:
cancel_link_text: Cancelar su código de barras
close_window: Ya puede cerrar esta ventana
deadline: Visite la Oficina de correos antes del %{deadline}
deadline_restart: Si supera la fecha límite, su información no se guardará y
Expand Down
1 change: 1 addition & 0 deletions config/locales/in_person_proofing/fr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ fr:
actuelle au bureau de poste.
learn_more: Apprendre encore plus
barcode:
cancel_link_text: Annulez votre code-barres
close_window: Vous pouvez maintenant fermer cette fenêtre
deadline: Visitez le bureau de poste d’ici %{deadline}
deadline_restart: Si vous partez après la date limite, vos informations ne
Expand Down
9 changes: 9 additions & 0 deletions spec/views/idv/in_person/ready_to_verify/show.html.erb_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,15 @@
end
end

it 'renders a cancel link' do
render

expect(rendered).to have_link(
t('in_person_proofing.body.barcode.cancel_link_text'),
href: idv_cancel_path(step: 'verify'),
)
end

context 'with enrollment where current address matches id' do
let(:current_address_matches_id) { true }

Expand Down