LG-8595: Label text for radio buttons should not be optional#7607
Merged
tomas-nava merged 1 commit intomainfrom Jan 10, 2023
Merged
LG-8595: Label text for radio buttons should not be optional#7607tomas-nava merged 1 commit intomainfrom
tomas-nava merged 1 commit intomainfrom
Conversation
changelog: Bug Fixes, In-person proofing, Show missing form label
Contributor
|
Hm, looks like this may also have regressed with other radio buttons, such as the "Create an account" language preference selection.
It's not really clear why it's acting differently for the legend, since my understanding of the intent of |
aduth
approved these changes
Jan 10, 2023
mitchellhenke
approved these changes
Jan 10, 2023
sheldon-b
approved these changes
Jan 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-8595
🛠 Summary of changes
The label text for radio buttons in the SimpleForm config was set
optionalin #7539. This caused the label for the radio buttons on the in-person proofing address page to stop rendering. This PR reverts radio button label text back touse.📜 Testing Plan
Navigate to the in-person proofing address page locally and confirm that the label for the radio buttons is visible.
👀 Screenshots
Before (form with missing label)
After (form showing label)