Merged
Conversation
…7493) Threatmetrix device profiling is designed to flag suspicious accounts. These accounts are not intended to have access to any IdV functionality after being flagged. This commit adds that functionality. Threatmetrix accounts can be relieved by changing the `deactivation_reason` in the profile. A follow-up PR will add tooling for this. [skip changelog]
…rs (#7485) A previous commit stopped reads from this column and ignored it. This commit goes back and cleans it up entirely. This commit also cleans up some job arguments that we changed in the same commit that stopped reads from this column. PR that stopped use of this column: #7446 [skip changelog]
* Permit generic type for request library * Install SWR * Refactor: use SWR; peel LocationResults into new component; * Exclude SWR from ie11 check * Consider ESM file extensions in Webpack file handling * Clear comments and unused variables * Specify type for request now * Add remaining translations; get full address string from arcgis; * changelog: Upcoming Features, In-Person Proofing, use SWR and refactor; prevent auto load * Lint * Add placeholder french translation * Drop the default transformKeys predicate and require consumer to specify * Rename prop to be more truthful * Wrap back button in PageFooter * Include formatting and divider Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
* Replace workflow name * [skip changelog] * Add lintfix to README * Update workflow names for RDP2 endpoints * Add license details to Instant Verify request method * Add configuration variables to README * lint fix * Test methods that rely on parsed Instant Verify response JSON * Remove unneeded newline * [skip changelog] * [skip changelog] * [skip changelog] * [skip changelog] * [skip changelog] * [skip changelog] * [skip changelog]
* remove prepare steps on prepare page * changelog: Improvements, Prepare step, remove prepare list from page for a/b testing * remove unused strings
) * Avoid ValidatedFieldComponent missing aria-describedby references changelog: Bug Fixes, Accessibility, Fix missing ID references for field descriptors * Fix specs * Remove unnecessary non-null operator * Add error-id as attribute of lg-validated-field Inspired by @svalexander's idea in #7488 Co-Authored-By: Shannon A <20867088+svalexander@users.noreply.github.com> * Try avoiding layout-affecting padding for empty error message May want to revisit. Could also consider ":empty" pseudo-selector * Make spec descriptor hint more realistic Avoid describedby associated to a label (which would be labelledby) * Sync MemorableDateComponent markup See: #7484 (comment) * Revert "Try avoiding layout-affecting padding for empty error message" This reverts commit d12c08a. * Update MemorableDate component to add error-id reference * Create helper methods to consolidate logic for hint/error ID * Restore display: none styling for valid field * Add describedby association as part of input validity handling * Remove accessible description assertion Previously, I picked "month" as an arbitrary field to find the error, but since now the field validity aria-describedby is managed per-field, the relationship would happen at the field level. We can (and ideally should) check the accessible description for the field we're interested in checking. * Avoid excess spaces in aria-describedby technically not an issue, but we should avoid having "empty" id refs be considered * Assert error message as hidden we could revert to what existed previously with "not_to have_css", but stronger guarantee that we check both the text is empty, and that it's explicitly present but not visible * Update MemorableDateComponent specs * Remove debugging code Co-authored-by: Shannon A <20867088+svalexander@users.noreply.github.com>
… an address (#7500) * modify screen reader to read headings * changelog: Upcoming Features, In-Person Proofing, Screenreader reads headings after search
aduth
requested review from
allthesignals,
eileen-nava,
jmax-gsa,
jskinne3,
mitchellhenke and
svalexander
mitchellhenke
approved these changes
Dec 19, 2022
mdiarra3
approved these changes
Dec 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements
Bug Fixes
Upcoming Features