Skip to content

LG-8312 Activate Threatmetrix for all user sessions#7446

Merged
jmhooper merged 6 commits intomainfrom
jmhooper-remove-sp-specific-threatmetrix-code
Dec 12, 2022
Merged

LG-8312 Activate Threatmetrix for all user sessions#7446
jmhooper merged 6 commits intomainfrom
jmhooper-remove-sp-specific-threatmetrix-code

Conversation

@jmhooper
Copy link
Copy Markdown
Contributor

@jmhooper jmhooper commented Dec 7, 2022

This code removes old code that enabled Threatmetrix for a limited set of SPs. This code was in place for testing Threatmetrics. Now that we are confident in the implementation we will be running it on all SPs.

A follow-up commit will be needed to drop database columns and clean up background job arguments.

This code removes old code that enabled Threatmetrix for a limited set of SPs. This code was in place for testing Threatmetrics. Now that we are confident in the implementation we will be running it on all SPs.

A follow-up commit will be needed to drop database columns and clean up background job arguments.

[skip changelog]
@jmhooper jmhooper marked this pull request as ready for review December 8, 2022 18:58
Copy link
Copy Markdown
Contributor

@solipet solipet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jmhooper jmhooper merged commit e0ec3cf into main Dec 12, 2022
@jmhooper jmhooper deleted the jmhooper-remove-sp-specific-threatmetrix-code branch December 12, 2022 16:09
jmhooper added a commit that referenced this pull request Dec 14, 2022
A previous commit stopped reads from this column and ignored it. This commit goes back and cleans it up entirely.

This commit also cleans up some job arguments that we changed in the same commit that stopped reads from this column.

PR that stopped use of this column: #7446

[skip changelog]
jmhooper added a commit that referenced this pull request Dec 15, 2022
…rs (#7485)

A previous commit stopped reads from this column and ignored it. This commit goes back and cleans it up entirely.

This commit also cleans up some job arguments that we changed in the same commit that stopped reads from this column.

PR that stopped use of this column: #7446

[skip changelog]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants