Send email deletion emails synchronously to avoid missing record errors#7495
Merged
mitchellhenke merged 1 commit intomainfrom Dec 15, 2022
Conversation
changelog: Bug Fixes, Background Jobs, Send email deletion emails synchronously to avoid missing record errors
mitchellhenke
force-pushed
the
mitchellhenke/send-email-deletion-notifications-synchronously
branch
from
4cff103 to
1844ffa
Compare
Contributor
|
Is this the same as what was discussed in this Slack thread (my fault for dropping the ball on following-up with a ticket)? In that thread I mentioned changing the email argument to a string. Do we need that? 🤔 I can't recall the thinking about that. Perhaps related to #7106? |
aduth
approved these changes
Dec 15, 2022
mitchellhenke
deleted the
mitchellhenke/send-email-deletion-notifications-synchronously
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
When a user deletes an email address, we send email notifications to all email addresses in the account (including the deleted one). This doesn't work so well when we try to send it asynchronously since the EmailAddress record is gone by the time it tries to run (NewRelic error).