Skip to content

Microoptimize reproof_for_irs to avoid database query #7307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduth merged 1 commit into from
Nov 8, 2022
Merged

Microoptimize reproof_for_irs to avoid database query #7307

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/decorators/user_decorator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@ def identity_verified?(service_provider: nil)
end

def reproof_for_irs?(service_provider:)
return false unless user.active_profile.present?
return false unless service_provider&.irs_attempts_api_enabled
return false unless user.active_profile.present?
!user.active_profile.initiating_service_provider&.irs_attempts_api_enabled
end

Expand Down