Skip to content

Additional OTP language updates #7300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthinz merged 2 commits into from
Nov 7, 2022
Merged

Additional OTP language updates #7300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a9da30
"Get another code" -> "Send another code"
matthinz Nov 4, 2022
9ab73d7
get_another_code -> send_another_code
matthinz Nov 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/views/idv/otp_verification/show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
outline: true,
icon: :loop,
class: 'margin-bottom-4',
).with_content(t('links.two_factor_authentication.get_another_code')) %>
).with_content(t('links.two_factor_authentication.send_another_code')) %>
Copy link
Copy Markdown
Contributor

@zachmargolis zachmargolis Nov 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO I don't think the change is big enough to merit renaming the key? But also fine to change it too

Copy link
Copy Markdown
Contributor Author

@matthinz matthinz Nov 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm not sure where that line is.


<p>
<%= t('instructions.mfa.wrong_number') %><br>
Expand Down
2 changes: 1 addition & 1 deletion app/views/two_factor_authentication/otp_verification/show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
outline: true,
icon: :loop,
class: 'margin-bottom-neg-1',
).with_content(t('links.two_factor_authentication.get_another_code')) %>
).with_content(t('links.two_factor_authentication.send_another_code')) %>
<% end %>

<% if @presenter.unconfirmed_phone? %>
Expand Down
2 changes: 1 addition & 1 deletion config/locales/links/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,5 @@ en:
reverify: Please verify your identity again.
sign_out: Sign out
two_factor_authentication:
get_another_code: Get another code
send_another_code: Send another code
what_is_totp: What is an authentication app?
2 changes: 1 addition & 1 deletion config/locales/links/es.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,5 @@ es:
reverify: Verifique su identidad nuevamente.
sign_out: Cerrar sesión
two_factor_authentication:
get_another_code: Obtener otro código
send_another_code: Enviar otro código
what_is_totp: '¿Qué es una app de autenticación?'
2 changes: 1 addition & 1 deletion config/locales/links/fr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,5 @@ fr:
reverify: Veuillez vérifier votre identité de nouveau.
sign_out: Déconnexion
two_factor_authentication:
get_another_code: Obtenir un autre code
send_another_code: Envoyer un autre code
what_is_totp: Qu’est-ce qu’une application d’authentification?
4 changes: 2 additions & 2 deletions spec/features/idv/phone_otp_rate_limiting_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
complete_idv_steps_before_phone_otp_verification_step(user)

(max_attempts - 1).times do
click_on t('links.two_factor_authentication.get_another_code')
click_on t('links.two_factor_authentication.send_another_code')
end

expect_max_otp_request_rate_limiting
Expand All @@ -48,7 +48,7 @@
choose_idv_otp_delivery_method_sms

# nth attempt
click_on t('links.two_factor_authentication.get_another_code')
click_on t('links.two_factor_authentication.send_another_code')

expect_max_otp_request_rate_limiting
end
Expand Down
6 changes: 3 additions & 3 deletions spec/features/idv/steps/phone_otp_verification_step_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@

sent_message_count = Telephony::Test::Message.messages.count

click_on t('links.two_factor_authentication.get_another_code')
click_on t('links.two_factor_authentication.send_another_code')

expect(Telephony::Test::Message.messages.count).to eq(sent_message_count + 1)
expect(current_path).to eq(idv_otp_verification_path)
Expand All @@ -73,7 +73,7 @@
)
allow(Telephony).to receive(:send_confirmation_otp).and_return(response)

click_on t('links.two_factor_authentication.get_another_code')
click_on t('links.two_factor_authentication.send_another_code')

expect(page).to have_content(I18n.t('telephony.error.friendly_message.generic'))
expect(page).to have_current_path(idv_phone_path)
Expand All @@ -92,7 +92,7 @@
)
allow(Telephony).to receive(:send_confirmation_otp).and_return(response)

click_on t('links.two_factor_authentication.get_another_code')
click_on t('links.two_factor_authentication.send_another_code')

expect(page).to have_content(calling_area_error.friendly_message)
expect(page).to have_current_path(idv_phone_path)
Expand Down
2 changes: 1 addition & 1 deletion spec/features/two_factor_authentication/change_factor_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
travel(IdentityConfig.store.reauthn_window + 1)
visit manage_phone_path(id: phone_configuration)
complete_2fa_confirmation_without_entering_otp
click_link t('links.two_factor_authentication.get_another_code')
click_link t('links.two_factor_authentication.send_another_code')

expect(Telephony).to have_received(:send_authentication_otp).with(
otp: user.reload.direct_otp,
Expand Down
2 changes: 1 addition & 1 deletion spec/support/shared_examples/phone/otp_confirmation.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
it 'allows the user to resend an OTP and confirm with the new OTP' do
visit_otp_confirmation(delivery_method)
old_code = last_otp(delivery_method)
click_on t('links.two_factor_authentication.get_another_code')
click_on t('links.two_factor_authentication.send_another_code')
new_code = last_otp(delivery_method)

expect(old_code).to_not eq(new_code)
Expand Down
4 changes: 2 additions & 2 deletions spec/support/shared_examples/phone/rate_limitting.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
it 'limits the number of times the user can resend an OTP' do
visit_otp_confirmation(delivery_method)
2.times do
click_on t('links.two_factor_authentication.get_another_code')
click_on t('links.two_factor_authentication.send_another_code')
end

expect(page).to have_content(t('two_factor_authentication.max_otp_requests_reached'))
Expand All @@ -13,7 +13,7 @@
it 'limits the number of times a code can be sent to a phone across accounts' do
visit_otp_confirmation(delivery_method)
2.times do
click_on t('links.two_factor_authentication.get_another_code')
click_on t('links.two_factor_authentication.send_another_code')
end

Capybara.reset_session!
Expand Down
4 changes: 2 additions & 2 deletions spec/views/two_factor_authentication/otp_verification/show.html.erb_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@
)

expect(rendered).to have_link(
t('links.two_factor_authentication.get_another_code'),
t('links.two_factor_authentication.send_another_code'),
href: resend_path,
)
end
Expand Down Expand Up @@ -207,7 +207,7 @@
)

expect(rendered).to have_link(
t('links.two_factor_authentication.get_another_code'),
t('links.two_factor_authentication.send_another_code'),
href: resend_path,
)
end
Expand Down