Use a connection pool for redis-session-store (forked gem)#7290
Closed
zachmargolis wants to merge 8 commits intomainfrom
Closed
Use a connection pool for redis-session-store (forked gem)#7290zachmargolis wants to merge 8 commits intomainfrom
zachmargolis wants to merge 8 commits intomainfrom
Conversation
- Via ConnectionPool::Wrapper which may be slightly slower [skip changelog]
zachmargolis
requested review from
henrydrichardson,
mitchellhenke and
timothy-spencer
zachmargolis
changed the title
- just like Pii::SessionStore - they probably should not be separate classes in the first place
zachmargolis
commented
Nov 4, 2022
This reverts commit 7ae9f78.
…-connections-forked
Contributor
Author
|
Closing for now, the #7289 seems to have given us some wins for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to https://github.com/18F/identity-idp/pull/7289/files#r1013429818
Related PR: 18F/redis-session-store#8